Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: try to fix download racing bugs #2458

Merged
merged 9 commits into from
Oct 16, 2024
Merged

*: try to fix download racing bugs #2458

merged 9 commits into from
Oct 16, 2024

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Sep 13, 2024

What problem does this PR solve?

Close #2452

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

Fix downloads racing bugs that results into 'No such file or directory'

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from xhebox, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 13, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 13, 2024
@xhebox
fix workflow
8f5b69a 
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot bot removed the lgtm label Sep 19, 2024
@xhebox
fix UT
815f514 
Signed-off-by: xhe <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 16, 2024
@xhebox
fix UT
07f46b5 
Signed-off-by: xhe <[email protected]>
@xhebox
stable test
2d9b7d9 
Signed-off-by: xhe <[email protected]>
@xhebox
stable test
11578be 
Signed-off-by: xhe <[email protected]>
@xhebox
stable test
793d505 
Signed-off-by: xhe <[email protected]>
@xhebox
stable test
1c64b69 
Signed-off-by: xhe <[email protected]>
@xhebox
stable test
2799709 
Signed-off-by: xhe <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes missing coverage. Please review.

Project coverage is 44.21%. Comparing base (c1a14a5) to head (f3ab291).
Report is 1 commits behind head on master.

❗ Current head f3ab291 differs from pull request most recent head 2799709

Please upload reports for the commit 2799709 to get more accurate results.

Files with missing lines Patch % Lines
pkg/repository/v1_repository.go 33.33% 4 Missing and 2 partials ⚠️
pkg/repository/v1manifest/local_manifests.go 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c1a14a5) and HEAD (f3ab291). Click for more details.

HEAD has 30 uploads less than BASE
Flag BASE (c1a14a5) HEAD (f3ab291)
unittest 2 0
cluster 31 3
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2458       +/-   ##
===========================================
- Coverage   55.14%   44.21%   -10.92%     
===========================================
  Files         334      333        -1     
  Lines       36026    36108       +82     
===========================================
- Hits        19863    15965     -3898     
- Misses      13777    18001     +4224     
+ Partials     2386     2142      -244
Flag Coverage Δ
cluster 35.18% <30.77%> (-9.59%) ⬇️
dm 25.16% <30.77%> (-0.09%) ⬇️
playground 16.20% <25.00%> (+0.36%) ⬆️
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 16, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-13 03:06:36.286451011 +0000 UTC m=+584866.026874965: ☑️ agreed by kaaaaaaang.
  • 2024-09-19 01:26:31.987798749 +0000 UTC m=+1097261.728222689: ✖️🔁 reset by xhebox.
  • 2024-10-16 06:45:20.003091746 +0000 UTC m=+426317.152001594: ☑️ agreed by kaaaaaaang.

@xhebox xhebox merged commit 964b40b into pingcap:master Oct 16, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaaaaaaang kaaaaaaang kaaaaaaang approved these changes

@nexustar nexustar Awaiting requested review from nexustar

Assignees
No one assigned
Labels
lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@xhebox @codecov-commenter @kaaaaaaang