Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pysolar numpy-aware #72

Open
fsteinmetz opened this issue Apr 9, 2018 · 2 comments
Open

Make pysolar numpy-aware #72

fsteinmetz opened this issue Apr 9, 2018 · 2 comments

Comments

@fsteinmetz
Copy link

I understand there may be a will to have pysolar only depend on the standard library.
However for some applications it would be extremely useful to use numpy instead of math, in order to vectorize operations, and support array inputs/outputs to most of pysolar's functions.
Maybe even support both using something like:

try:
    from numpy import pi, radians, arctan as atan, arcsin as asin # etc
except ModuleNotFoundError:
    from math import pi, radians, atan, asin # etc
@pingswept
Copy link
Owner

Support of Numpy is desirable, as long as it doesn't become a dependency. The approach outlined above sounds good to me.

Patches welcome!

@pingswept
Copy link
Owner

Just a note that this is partially completed, as described in #74. I'm not sure what work remains, but help is still wanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants