Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need docs/content/en/docs? #4454

Closed
kentakozuka opened this issue Jun 28, 2023 · 10 comments
Closed

Do we need docs/content/en/docs? #4454

kentakozuka opened this issue Jun 28, 2023 · 10 comments
Labels
kind/enhancement New feature or request

Comments

@kentakozuka
Copy link
Member

kentakozuka commented Jun 28, 2023

docs/ is supposed to be the same with docs of the latest version(e.g. docs-v0.44.x/).

Also, When we jump "Documentation" from the top page with a specific version being selected, we are navigated to docs/. This should be docs of the selected version.

@kentakozuka kentakozuka added the kind/enhancement New feature or request label Jun 28, 2023
@khanhtc1202
Copy link
Member

khanhtc1202 commented Jun 28, 2023

This is a legacy problem. Previously, we only have one single docs which is /docs/, and after that, when we started versioning the docs, I thought links to /docs/ be referred out where (on other sites blog, for instance) should be kept alive. That's why we decided that we have to keep /docs and make it points to the latest version docs.

To ensure users who read about pipecd from other blogs do not get 404 not found error, we have to:

  • configure to redirect all /docs/ to the "right" URL which we not sure what is what
  • keep /docs/ and make it as same as the latest <- currently do this, since it's the simplest

WDYT? 🤔

@khanhtc1202
Copy link
Member

When we jump "Documentation" from the top page with a specific version being selected, we are navigated to docs/. This should be docs of the selected version.

I think it works as expected, isn't it? 🤔

Kapture.2023-06-28.at.22.02.22.mp4

@kentakozuka
Copy link
Member Author

kentakozuka commented Jun 28, 2023

I meant this;

Screen.Recording.2023-06-29.at.07.58.56.mov

But if /docs is the same as the latest version, it could be the expected behavior...

@kentakozuka
Copy link
Member Author

kentakozuka commented Jun 28, 2023

I did not know the history of docs. That's good to know. Thanks!

So how about this?

  • remove /docs/.
  • configure to redirect all /docs/ to the latest URL (e.g. /docs-v0.44.0x on 2023-06-29)

because /docs/ and the latest versioned docs contain the same content.

@khanhtc1202
Copy link
Member

Do you mean after that (on version v0.45.x release and so on), we don't do redirection any more, any require versioning docs url from now on 👀

@kentakozuka
Copy link
Member Author

I meant we would do redirect /docs/ to the latest version.
/docs will be removed because all accesses to /docs/ will be redirected to the latest docs.

@kentakozuka
Copy link
Member Author

@khanhtc1202
How about this simple way to do?
#4458

  • Remove /docs-dev
  • Treat /docs/ as master(I guess we already do that in our mind)

I looked at KubeFlow and they seem to do in this way.
Screenshot 2023-06-30 at 08 04 35

@khanhtc1202
Copy link
Member

Sorry but I don't think that way. First, the master means to dev version of the docs. Since it is docs for the not yet released version, I prefer to use the word dev over latest or master to mention that it's dev (not released) directly.

And besides, I don't think treating the /docs as master/dev/latest is a good idea. It should be treated as stable/latest-released docs, since it clearly means it's the documentation (users may don't aware of docs has other versions so /docs can be used as the only one)

This is the versioning of argocd (latest: dev / stable: latest released / versioning: ...)

Screen Shot 2023-06-30 at 10 27 47

@kentakozuka
Copy link
Member Author

I just started to think the current directory structure and writing flow is good enough.

  • We already have make gen/stable-docs.
  • Removing /docs/ and setting up the redirect to the latest version is not that easy.

So I'm thinking to close this issue until someone has the same thought.
@khanhtc1202 wdyt?

@khanhtc1202
Copy link
Member

For sure, let's make a discussion for this later if we have a better idea around the docs 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants