Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECS] Support modifying listener rules other than defaults #4725

Closed
t-kikuc opened this issue Dec 17, 2023 · 3 comments · Fixed by #4733
Closed

[ECS] Support modifying listener rules other than defaults #4725

t-kikuc opened this issue Dec 17, 2023 · 3 comments · Fixed by #4733
Labels
kind/enhancement New feature or request

Comments

@t-kikuc
Copy link
Member

t-kikuc commented Dec 17, 2023

What would you like to be added:

Select which listener rules to modify.

Why is this needed:

We need to specify the rules to modify other than default one.
For example, one listener has multiple listener rules and they have different path conditions and target services.

Now PipeCD updates only the Default rule.
So even if we want to modify the rule-web below, only the Default rule is modified.

image

@t-kikuc t-kikuc added the kind/enhancement New feature or request label Dec 17, 2023
@t-kikuc
Copy link
Member Author

t-kikuc commented Dec 17, 2023

This is related to #4530

@t-kikuc
Copy link
Member Author

t-kikuc commented Dec 17, 2023

How to use this feature?:

Moved the comment to #4726

@moko-poi
Copy link
Contributor

👍

@t-kikuc t-kikuc changed the title [ECS] Support selection of listener rules to modify [ECS] Support modifying listener rules other than defaults Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
2 participants