Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't execute git commit when we use pipectl event register --contexts because of the git version #5320

Open
ffjlabo opened this issue Nov 8, 2024 · 1 comment
Labels
kind/bug Something isn't working

Comments

@ffjlabo
Copy link
Member

ffjlabo commented Nov 8, 2024

What happened:

In v0.49.3, we add the new feature pipectl event register --contexts #5028
The event watcher automatically adds the commit with the trailer.

The trailer feature is introduced from git 2.32.o ref: https://github.com/git/git/blob/master/Documentation/RelNotes/2.32.0.txt#L55
git 2.33.0 ref: https://github.blog/open-source/git/highlights-from-git-2-33/

But the git version in the launcher and piped container is 2.30.6.

docker run --rm -i -t --entrypoint /bin/sh ghcr.io/pipe-cd/launcher:v0.49.3 
/ $ git --version
git version 2.30.6
/ $ cd
~ $ mkdir test
~ $ cd test/
~/test $ git init
~/test $ touch README.md
~/test $ git add README.md
~/test $ git commit -m "Initial commit" --trailer "Test: hoge"
error: unknown option `trailer'
usage: git commit [<options>] [--] <pathspec>...
/ $ git --version
git version 2.30.6
/ $ cd
~ $ mkdir test
~/test $ git init
~/test $ touch README.md
~/test $ git add README.md
~/test $ git comit -m "test" --trailer "Test: hoge"
error: unknown option `trailer'
usage: git commit [<options>] [--] <pathspec>...

What you expected to happen:

How to reproduce it:

Environment:

  • piped version:
  • control-plane version:
  • Others:
@ffjlabo ffjlabo added the kind/bug Something isn't working label Nov 8, 2024
@ffjlabo
Copy link
Member Author

ffjlabo commented Nov 8, 2024

Thank you for investigation 🙏 @peaceiris

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant