Introduce plugin logpersister package #5342
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Introduce plugin logpsersister package
Why we need it:
In pipedv0, we use logPersister as the writer for stage logs (which will later be used to show stage logs on UI). In this PR, I created
pkg/plugin/logpersister
package, with the same responsibility, but instead of sending the stage log directly to the controlplane, it sends to piped plugin-api then piped will send it to the controlplane.Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: