Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce plugin logpersister package #5342

Merged
merged 2 commits into from
Nov 15, 2024
Merged

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Nov 15, 2024

What this PR does:

Introduce plugin logpsersister package

Why we need it:

In pipedv0, we use logPersister as the writer for stage logs (which will later be used to show stage logs on UI). In this PR, I created pkg/plugin/logpersister package, with the same responsibility, but instead of sending the stage log directly to the controlplane, it sends to piped plugin-api then piped will send it to the controlplane.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes missing coverage. Please review.

Project coverage is 25.28%. Comparing base (519d3fc) to head (cb668cf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/cmd/piped/grpcapi/plugin_api.go 0.00% 35 Missing ⚠️
pkg/app/pipedv1/controller/controller.go 0.00% 6 Missing ⚠️
pkg/app/pipedv1/controller/scheduler.go 0.00% 4 Missing ⚠️
pkg/plugin/logpersister/persister.go 0.00% 2 Missing ⚠️
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5342      +/-   ##
==========================================
- Coverage   25.29%   25.28%   -0.02%     
==========================================
  Files         444      444              
  Lines       47650    47656       +6     
==========================================
- Hits        12055    12049       -6     
- Misses      34652    34664      +12     
  Partials      943      943              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: khanhtc1202 <[email protected]>
Copy link
Contributor

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit 23eddac into master Nov 15, 2024
16 of 18 checks passed
@khanhtc1202 khanhtc1202 deleted the create-plugin-logpersister branch November 15, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants