Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newline weirdness on Azure #2839

Open
mpenkov opened this issue May 14, 2020 · 0 comments
Open

Fix newline weirdness on Azure #2839

mpenkov opened this issue May 14, 2020 · 0 comments
Labels
housekeeping internal tasks and processes

Comments

@mpenkov
Copy link
Collaborator

mpenkov commented May 14, 2020

Some of our tests were failing on Azure because of LF/CRLF weirdness once the .gitattributes file was deleted. In the interest of moving things along, I've disabled those tests (look for AZURE in gensim/test/test_*.py).

Ideally, we should make these tests run and pass.


I have 2 ideas

  • apply .gitattribute only for the concrete subset of files that fail azure (replace * with paths). This will definitely fix azure, but I'm not sure does this avoid effect with "modified files" that Gordon described
  • "re-checkout" repo in azure with generated .gitattribute in runtime, this definitely avoid Gordon issue, but not sure will azure work with it (.gitattributes works in a pretty strange way for me, looks like this applied on clone, not on local checkout, worth to investigate)

Gordon right: hacks for CI shouldn't affect contributors

Originally posted by @menshikh-iv in #2836 (comment)

@mpenkov mpenkov added the housekeeping internal tasks and processes label Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping internal tasks and processes
Projects
None yet
Development

No branches or pull requests

1 participant