Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable tests for Keras integration #2908

Closed
piskvorky opened this issue Jul 30, 2020 · 1 comment · Fixed by #2937
Closed

Re-enable tests for Keras integration #2908

piskvorky opened this issue Jul 30, 2020 · 1 comment · Fixed by #2937
Labels
housekeeping internal tasks and processes testing Issue related with testing (code, documentation, etc)
Milestone
4.0.0

Comments

@piskvorky
Copy link
Owner

piskvorky commented Jul 30, 2020 •
edited
Loading

The Keras tests started failing on py3.7 + 3.8 in #2899:

https://travis-ci.org/github/RaRe-Technologies/gensim/jobs/713448950#L862

None of the changes in that PR seem related to these errors, so probably some TF / Keras weirdness again.

Task: Look into it and either fix, or rip out that entire Keras submodule. One of the contributed / never properly vetted features. Or Keras is that unstable… same difference.
@piskvorky piskvorky added testing Issue related with testing (code, documentation, etc) housekeeping internal tasks and processes labels Jul 30, 2020
@piskvorky piskvorky mentioned this issue Jul 30, 2020
Merged
10 tasks
@piskvorky piskvorky added this to the 4.0.0 milestone Jul 30, 2020
@piskvorky piskvorky mentioned this issue Jul 31, 2020
Open
@piskvorky
Copy link
Owner Author

Related: #2911.

@piskvorky piskvorky mentioned this issue Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
housekeeping internal tasks and processes testing Issue related with testing (code, documentation, etc)
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Remove Keras dependency piskvorky/gensim
1 participant
@piskvorky