Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete triage of PRs for version 4.1.0 #3200

Closed
mpenkov opened this issue Jul 22, 2021 · 4 comments
Closed

Complete triage of PRs for version 4.1.0 #3200

mpenkov opened this issue Jul 22, 2021 · 4 comments
Assignees
Labels
housekeeping internal tasks and processes

Comments

@mpenkov
Copy link
Collaborator

mpenkov commented Jul 22, 2021

Gentlemen, there are 6 in-progress PRs that I initially marked for inclusion into the 4.1.0 release here.

I propose that we deal with them after the release, as they do not appear to be critical, and need not hold back the release. Can you please have a look at let me know?

@mpenkov mpenkov added the housekeeping internal tasks and processes label Jul 22, 2021
@piskvorky
Copy link
Owner

I don't see anything under that link. Wrong URL?

@mpenkov
Copy link
Collaborator Author

mpenkov commented Jul 22, 2021

Hmm, works for me. Maybe github is having some sort of glitch.

Another way to get to it is to go to https://github.com/RaRe-Technologies/gensim/projects and click on the first project in the list (PR triage 2021-06).

@piskvorky
Copy link
Owner

piskvorky commented Jul 22, 2021

Yes, that Github page loads now. Weird.

By "in-progress", you mean the "Needs work before merge" column, right?

If so, the only PR worth considering as "urgent" (to be included in 4.1.0) is #3000. That's because it changes / cleans up the API, and these things are always better done sooner rather than later.

The rest would be great to have too, but can wait, nothing critical / urgent.

@mpenkov
Copy link
Collaborator Author

mpenkov commented Jul 23, 2021

OK, I'll push #3000 over the line, and then after we complete #3199 we can initiate the release.

@mpenkov mpenkov closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping internal tasks and processes
Projects
None yet
Development

No branches or pull requests

3 participants