Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scipy probably not needed in [build-system.requires] table #3536

Closed
filip-komarzyniec opened this issue Jun 6, 2024 · 2 comments · Fixed by #3538
Closed

scipy probably not needed in [build-system.requires] table #3536

filip-komarzyniec opened this issue Jun 6, 2024 · 2 comments · Fixed by #3538

Comments

@filip-komarzyniec
Copy link
Contributor

Problem description

I believe that specifying scipy as a build-only dependency is unnecessary.

Pip builds the library in isolated environment (by default) where it first downloads (and alternatively builds) build-only dependencies. This behaviour creates additional problems for architectures for which there are not many .whl distributions, like e.g. ppc64le.

Steps/code/corpus to reproduce

  1. create an environment where there is already an older scipy library version installed

cd gensim/
pip install . 
  1. As there is no gensim .whl distribution for ppc64le, pip will try building gensim in a new isolated environment with build-only dependencies.
    As there is no scipy .whl distribution for ppc64le either, pip will try building that as well.
    Despite the fact that scipy is already installed in desired version within the target environment.
    Not only there will be a scipy version mismatch (pip will be building the latest version in the isolated environment) but it will also:
    • significantly prolong the install phase, as scipy takes relatively long to build from source,
    • create additional dependencies mess, as scipy build requires multiple other dependencies and system-level libraries

Desired resolution

I've tested locally installing gensim with modified pyproject.toml file (deleted scipy) and it works as expected.
Is there any other logic that does not allow deleting scipy as a build-only dependency?

Versions

gensim>4.3.*

@piskvorky piskvorky added this to the Spring 2024 release milestone Jun 6, 2024
@mpenkov
Copy link
Collaborator

mpenkov commented Jun 11, 2024

Are you interested in making a PR @filip-komarzyniec ?

@filip-komarzyniec
Copy link
Contributor Author

Sure, I'll be happy to, thanks!
I'll issue it shortly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants