Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong example in README #55

Open
jcubic opened this issue Jun 25, 2020 · 3 comments
Open

Wrong example in README #55

jcubic opened this issue Jun 25, 2020 · 3 comments

Comments

@jcubic
Copy link

jcubic commented Jun 25, 2020

One of the examples shows:

cowsay.say({
	text : "I'm a moooodule",
	e : "oO",
	T : "U "
})

which does't work (eyes and tongue don't change), other example says:

console.log(think({
  text: 'grazing in the browser',
  cow: SQUIRREL,
  eyes: 'pp',
  tongue: ';;',
}));

that API works.

@Questionm
Copy link

in my case

cowsay.say({
	text : "I'm a moooodule",
	e : "oO",
	T : "U "
})

works

But

console.log(think({
  text: 'grazing in the browser',
  cow: SQUIRREL,
  eyes: 'pp',
  tongue: ';;',
}));

no. And the cow: change animal option not working in neither cases // still confused how to change animal successfully

@jcubic
Copy link
Author

jcubic commented Jun 30, 2020

There are some inconsistencies, I think the best is to provides both APIs for both say and think.
Here is was testing the APIin broser at CodePen

@jcubic
Copy link
Author

jcubic commented Jun 30, 2020

I've just tested both say and think at CodePen and in browser it works with longer names options. They eyes are changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants