Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: screenshot tests for result #7

Open
sashasushko opened this issue Nov 9, 2022 · 0 comments
Open

feat: screenshot tests for result #7

sashasushko opened this issue Nov 9, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@sashasushko
Copy link
Contributor

Optimization of the fallback font is based on recalculation of its parameters. One of them is the width of the font. Unfortunately, current optimization is not one hundred percent and requires constant improvement. Screenshot tests would help in this.

How it can work

  • We have some page with two block overlay. For bottom block we use font-face with fallback font. For top block - with real font (see reference)
  • Then we run screenshot tests for getting the standard once.
  • After some changes in calculation logic we get new @font-face, place it to this page and run screenshot tests again.
  • Then we look at the results and decide - keep changes or revert.
@sashasushko sashasushko added the enhancement New feature or request label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sashasushko