Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure MV2/MV3 sidebar controller behavior is consistent #8227

Closed
3 of 4 tasks
twschiller opened this issue Apr 11, 2024 · 0 comments · Fixed by #8299
Closed
3 of 4 tasks

Ensure MV2/MV3 sidebar controller behavior is consistent #8227

twschiller opened this issue Apr 11, 2024 · 0 comments · Fixed by #8299
Assignees
Labels
bug Something isn't working mv3

Comments

@twschiller
Copy link
Contributor

twschiller commented Apr 11, 2024

Context

  • In general, the top-level frame should control the sidebar. In these cases, the use must use target: top on the brick when calling it from a frame
  • However, some operations might be safe to call from a frame (e.g., open sidebar), and we might not want to require explicitly using target: top
  • However, in MV3, opening the sidebar must be done from a user gesture, so we have to be careful about where the event is actually run

Sidebar Controller Methods

Test Mods:

Method Behavior Inventory

  • showSidebar
    • MV2 behavior: ✅ can run in any frame
    • MV3 behavior: 🟡 can run in any frame -- shows the user gesture dialog in the frame if there's too long of a delay
  • hideSidebar
    • MV2 behavior: ✅ can run in any frame
    • MV3 behavior: ✅ can run in any frame
  • showSidebarForm
  • showTemporarySidebarPanel: Fixed in 00ea332
    • MV2 behavior: errors out. The sidebar opens, but no panel is shown with error "Cannot add temporary sidebar panel if the sidebar is not visible" (like the form, we should prevent it from being run from a frame)
    • MV3 behavior: 🟡 shows the document -- but does not continue after closing/submitting the panel

Out of Scope

Related Issues/PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mv3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant