Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: addStarterBrick e2e tests flaky on sidebar ping #9011

Closed
mnholtz opened this issue Aug 14, 2024 · 2 comments
Closed

Bug: addStarterBrick e2e tests flaky on sidebar ping #9011

mnholtz opened this issue Aug 14, 2024 · 2 comments
Labels
bug Something isn't working testing

Comments

@mnholtz
Copy link
Collaborator

mnholtz commented Aug 14, 2024

End to end tests for addStarterBrick are intermittently failing on the Pre-release browser workflow, for both msedge-beta and msedge: https://github.com/pixiebrix/pixiebrix-extension/actions/runs/10381677885/job/28771479311

Tests seem to be failing consistently with the error The Sidebar is taking longer than expected to load. Retrying... when waiting for the sidebar to open.

Screenshot 2024-08-14 at 12.09.49 PM.png

@mnholtz mnholtz added bug Something isn't working testing labels Aug 14, 2024
@grahamlangford grahamlangford self-assigned this Aug 29, 2024
@grahamlangford
Copy link
Collaborator

I spent a day digging into this bug. This only appears to happen when running the e2e tests. When adding a sidepanel starterbrick using the Page Editor, the sidepanel should open automatically, but it doesn't. Nor does the gesture popover appear.

Findings:

  • Cannot be replicated in MS Edge outside Playwright
    • Tested with the Page Editor open in another tab to as closely simulate the test as possible and still could not replicate
  • Can be replicated in MS Edge launched by Playwright
  • When running the e2e test, if I pause test execution as soon as the test had finished starting up, I can replicate in the Playwright-launched Edge browser (same Edge version as when not using Playwright)
  • Tested with old versions of the Extension from before the flakiness appeared, but was still able to reproduce in Playwright
  • Confirmed that the chrome.sidePanel.open method is being called

@fungairino
Copy link
Collaborator

This should be resolved now with #9087 closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working testing
Projects
None yet
Development

No branches or pull requests

3 participants