Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slice 5 - Convert “Move from mod” action to “Move to Mod” and adjust Copy action #9101

Closed
BLoe opened this issue Sep 5, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request page editor user experience Improve the user experience (UX)

Comments

@BLoe
Copy link
Contributor

BLoe commented Sep 5, 2024

Slice spec here

  • Engineering Considerations/Implementation Sketch
    • Delete the current move from mod modal
      • onRemoveFromMod prop in ActionMenu
      • MoveFromModModal
      • update selectEditorModalVisibilities
      • removeModComponentFormStateFromMod redux action/reducer
    • We can keep using the keepLocalCopyOnCreateMod field in redux
    • Recreate MoveFromModModal
      • Rename remaining pieces
        • showRemoveFromModModalshowMoveFromModModal redux action/reducer
        • REMOVE_FROM_MODMOVE_FROM_MOD modal key
      • Copy the "modId" field from AddtoModModal, and all the pieces required for it
      • select the keepLocalCopyOnCreateMod from redux
        • Change modal title and submit button copy based on the flag, see wireframe above
      • Add an input param to the cloneActiveModComponent thunk
        • modMetadata?: ModMetadata
        • cloned component has the mod (re-)assigned if passed in
          • cloned component should have optionsArgs overwritten by the destination mod’s options (options pulled from activated components of that mod)
      • Submit handler has similar logic as AddToModalModal
        • If new mod is selected, show the create mod modal
          • Change showCreateModModal action creator to make the keepLocalCopy payload optional, don’t update the flag if it’s not passed in (was already set here, but we still need to support the payload for other call sites)
          • CreateModModal should still basically work the same
        • if mod is selected, call the cloneActiveModComponent with new mod metadata param
    • Add new redux action showMoveFromModModal
      • keepLocalCopy payload param, set the redux flag keepLocalCopyOnCreateMod
    • Change ActionMenu props
      • onCloneonCopy
        • dipatch(showMoveFromModModal({ keepLocalCopy: true })
      • onAddToModonMove
        • dipatch(showMoveFromModModal({ keepLocalCopy: false })
@BLoe BLoe self-assigned this Sep 5, 2024
@twschiller twschiller added enhancement New feature or request user experience Improve the user experience (UX) page editor labels Sep 9, 2024
@grahamlangford
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request page editor user experience Improve the user experience (UX)
Projects
None yet
3 participants