Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EINVAL instead of ENOTSUP on Solaris #67

Closed
greatroar opened this issue Jul 30, 2022 · 2 comments · Fixed by #68
Closed

EINVAL instead of ENOTSUP on Solaris #67

greatroar opened this issue Jul 30, 2022 · 2 comments · Fixed by #68

Comments

@greatroar
Copy link
Contributor

On Linux and Darwin at least, xattr.List returns ENOTSUP when the operation is not supported on a file. On Solaris, the openat call fails with EINVAL for the O_XATTR flag. This presumably applies to all operations, but in restic/restic#3839 we have a failure from List specifically.

We could fix this in restic, but since pkg/xattr already tries to simulate the Linux/BSD interface on Solaris, maybe this library could change the EINVAL to ENOTSUP and make porting to Solaris easier for everyone?
@kuba-- kuba-- mentioned this issue Aug 2, 2022
Merged
@kuba--
Copy link
Member

kuba-- commented Aug 2, 2022

@greatroar - PTAL if this quick fix (#68) works for you on solaris.

@kuba--
Copy link
Member

kuba-- commented Aug 5, 2022

@greatroar - ☝🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

(Solaris) return ENOTSUP on unix.Openat error pkg/xattr
2 participants
@kuba-- @greatroar