Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plot.setData() fails when a series has no data. #9

Open
Quedale opened this issue Nov 2, 2017 · 0 comments
Open

plot.setData() fails when a series has no data. #9

Quedale opened this issue Nov 2, 2017 · 0 comments

Comments

@Quedale
Copy link

Quedale commented Nov 2, 2017

  1. JavaScript function invokes "plot.setData" with a serie without data.
  2. reOrderBars function is invoked by the "processDatapoints" hook
  3. If the serie is valid, calculatePixel2WidthConvert is invoked.
  4. Method "calculPixel2XWidthConvert" invokes getAxeMinMaxValues
  5. Method "getAxeMinMaxValues" fails because there is no data length check. (undefined array index 0)

Note : Is it necessary for the getAxeMinMaxValues to loop through all series? It seems that the current code will only keep the min/max from the last serie in the array.

Other than that, great work!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Quedale