Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace dependency bumps don't count as changes #173

Open
Rigidity opened this issue Sep 27, 2024 · 1 comment
Open

Workspace dependency bumps don't count as changes #173

Rigidity opened this issue Sep 27, 2024 · 1 comment

Comments

@Rigidity
Copy link

I help maintain chia_rs, and we exclusively use workspace dependencies, to prevent duplication of versions. But because of this, the Cargo.toml isn't changed for individual workspace members when a version is bumped in the [workspace.dependencies], thus leading to that member being considered unchanged even though it needs to be bumped due to the dependency update.

The versions in the main Cargo.toml also don't seem to be bumped properly, as seen by this commit I had to add:
Chia-Network/chia_rs@8a04437

I'm not sure how best to create a minimal reproducible example, but I'm happy to help if I can. Also, thanks for making cargo-workspaces!

@pksunkara
Copy link
Owner

Possibly duplicate of #71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants