Case insensitive keys #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0c0444c.
…wncasing of keys as a before filter on database authentication module
|
Applied, thanks Andrew! I hope you enjoyed contributing to Devise! |
|
hi guys, is this slated for a 1.1.6, or should I move to 1.2rc? thanks. |
|
use 1.2.rc |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The included changes allow for case insensitive authentication keys. This is implemented as a configuration setting that specifies an array of keys that should be treated as case insensitive. The default is [ :email ].
This means that if a user signs up with [email protected] the user will be able to log in, reset password, unlock account, etc. with any casing of that email address (e.g. [email protected], [email protected]).
This is accomplished by downcasing all authentication keys in the case insensitive keys list upon creating a user and when authentication or finding a user.