Bug: When opening command palette: Command failed to execute: obsidian-linter:lint-all-files-in-folder

[chrisgrieser]

• I have verified that I am on the latest version of the Linter

Describe the Bug

An error occurs when opening the command palette for the first time after opening the vault. As far as I can tell, other than the error msg, there is nothing happening – but I do hope that the linter does not try to run commands simply when I open the command palette?

How to Reproduce

Steps to reproduce the behavior:

1. Open vault
2. Open Command palette
3. The error appears in the console:

Command failed to execute:  obsidian-linter:lint-all-files-in-folder
app.js:1 TypeError: Cannot read properties of null (reading 'parent')
    at Object.editorCheckCallback (plugin:obsidian-linter:307:3438)
    at e.mobileOnly.Il.isMobile.e.checkCallback (app.js:1:2068235)
    at app.js:1:2068860
    at Array.filter (<anonymous>)
    at e.listCommands (app.js:1:2068798)
    at e.getCommands (app.js:1:2660005)
    at t.getItems (app.js:1:2661047)
    at t.getSuggestions (app.js:1:1709952)
    at t.updateSuggestions (app.js:1:1709135)
    at t.onOpen (app.js:1:1708977)

Expected Behavior

No error happening.

Device

• Desktop
• Mobile

Additional Context

I am on Obsidian 1.7.3 (Insider release)

[pjkaufman]

Hey @chrisgrieser , are you using the latest BRAT release? I updated the minimum node version to 18, but recently saw that maybe some versions of Obsidian still expect 16.x.

[pjkaufman]

If it is having issues, I can see about fixing that, but the Linter is not running commands onload.

[pjkaufman]

I just double checked some code. I probably need to not assume that the editor callback will be called for a file object. I need to check if that exists and if it does not return false.

The error seems to be happening on the validation check that tries to check if a command should show in the editor.

[chrisgrieser]

Hey @chrisgrieser , are you using the latest BRAT release?

Nope, I am on the latest regular release of the linter

[pjkaufman]

Gotcha. So that rules out the node change. I am pretty sure it is the check on this line that needs extra guards:

obsidian-linter/src/main.ts

Line 235 in b29f66c

return !ctx.file.parent.isRoot();

Is the file you are looking at a custom view or is there no file open? Those are my two best guesses as to what would cause this unless it is a new bug where the ctx is not getting file info populated.

Edit: I cannot really look into this myself when it comes to reproducing the error until tomorrow.

[chrisgrieser]

it's a regular file.

Also, I double-checked, and it appears that the error only occurs after a vault reload (by running the command Reload app without saving), not on regular vault startup.

[pjkaufman]

Interesting. I will have to double check that then. Thanks for the reproduction information!

[pjkaufman]

I am not able to reproduce this issue, but I will add some logic to be more defensive when checking that logic to avoid an error.

[pjkaufman]

Here is a potential fix for this issue, but it does include the BRAT/beta features:
main.zip