Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gaussian splats not pickable #6974

Open
MAG-AdrianMeredith opened this issue Sep 19, 2024 · 2 comments
Open

Gaussian splats not pickable #6974

MAG-AdrianMeredith opened this issue Sep 19, 2024 · 2 comments
Assignees
Labels
area: graphics Graphics related issue bug

Comments

@MAG-AdrianMeredith
Copy link
Contributor

In gsplat-compressed-material.js there is the following code:

        #ifdef PICK_PASS
            if (B < 0.3) {
                discard;
            }
            return uColor;
        #endif

Where its expecting the colour picker color as uColor however this is no longer how the picker works and instead the color is derived from the mesh_instance_id parameter from

getPickOutput()

Steps to Reproduce

  1. add a gaussian splat
  2. attempt to pick it
  3. the pick colour is rendered black and no selection picked
@MAG-AdrianMeredith
Copy link
Contributor Author

Interesting theres no equivalent in gsplat-material.js.

@mvaligursky
Copy link
Contributor

yep definitely something we need to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: graphics Graphics related issue bug
Projects
None yet
Development

No branches or pull requests

3 participants