-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No place to specify a socks4/5 proxy, unlike AsyncHttpClient #418
Comments
Here's a repo of mine, doing some socks proxy work, with sttp, various backends, even old HttpUrlConnection |
Thanks for reporting this. I added this issue to the backlog, but it can take sometime before someone can find time to pick it. Would you be interested in sending a PR? |
Sorry, I am up to my eyeballs, currently its not a big issue for me as I can use other solutions (as above) Just found it odd/unexpected that play-ws didn't support it right now |
No worries. That is indeed odd. I guess this is not so common case otherwise it would have been reported before. If there is some interest in the community, it will get fixed sooner. Otherwise, it's when it becomes a priority. In any case, thanks for reporting it. |
There may well be another issue with ahc itself, that you might want to be aware of: |
Hi. Any progress on this? I would really like/need this feature. Thanks! |
You can pass in an already configured AHC client into Play that does have SOCKS configured: |
For the standalone client, you would do |
Unfortunately AHC doesn't do socks/tor name resolution properly, so I ended up using okttp, which does AsyncHttpClient/async-http-client#1682 https://gist.github.com/fancellu/df6dde59249edf8401b28bbc44a78cbc |
I can't see any place to specify that I'd like wsclient to use a socks proxy, whereas AsyncHttpClient can
https://www.javadoc.io/static/org.asynchttpclient/async-http-client/2.10.4/org/asynchttpclient/proxy/ProxyType.html
vs
play-ws/play-ws-standalone/src/main/scala/play/api/libs/ws/WS.scala
Line 81 in f4108ea
Thanks
The text was updated successfully, but these errors were encountered: