Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hover broken if plotDiv has a css transform (other than a translation) #1667

Closed
alexcjohnson opened this issue May 10, 2017 · 2 comments
Closed

Hover broken if plotDiv has a css transform (other than a translation) #1667

alexcjohnson opened this issue May 10, 2017 · 2 comments
Labels
bug something broken

Comments

@alexcjohnson
Copy link
Collaborator

If the page transforms the plotDiv element with a scale, rotation, or matrix, any call to getBoundingClientRect on an element within that div gives us misleading results and breaks hover effects. Certain getBoundingClientRect calls are necessary to find text sizing, but this should always be called on elements in gd._tester, which we attach directly to <body>, far off-screen. We should get rid of all other getBoundingClientRect calls. This will also be better for performance.

Calling this a bug, but we could also consider it a feature ("Add support for CSS transforms on the plotDiv and its parents")
@alexcjohnson alexcjohnson added the bug something broken label May 10, 2017
@rreusser
Copy link
Contributor

Possible duplicate of #888?

@alexcjohnson
Copy link
Collaborator Author

Ah thanks @rreusser - I'll move my comment here over there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rreusser @alexcjohnson