Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPLOM points not displayed with TypedArrays #2585

Closed
jonmmease opened this issue Apr 27, 2018 · 4 comments
Closed

SPLOM points not displayed with TypedArrays #2585

jonmmease opened this issue Apr 27, 2018 · 4 comments
Labels
bug something broken

Comments

@jonmmease
Copy link
Contributor

I'm not sure if this is a bug report or a feature request, but it seems that the new SPLOM trace type does not support typed arrays as the values property of a dimension (on version 1.36.1).

Codepen: https://codepen.io/anon/pen/LmbQdv

TESTER = document.getElementById('tester');

Plotly.plot( TESTER,
			  [{
    "type": "splom",
    "dimensions": [{
      "values": new Int32Array([1, 2, 3]),
      //"values": [1, 2, 3],
      "label": "A"
    }, {
      "values": new Int32Array([2, 5, 6]),
 	   //"values": [2, 5, 6],
      "label": "B"
    }]
  }]);

When I run this in Chrome (65.0.3325.181 (Official Build) (64-bit)) I see the axes displayed but no data points. I also get the following warning in the chrome developer console:

[.Offscreen-For-WebGL-0x7fdce8449c00]GL ERROR :GL_INVALID_OPERATION : glDrawArrays: attempt to access out of range vertices in attribute 3

If the Int32Arrays are replaced by standard arrays then the points display as I would expect.

@etpinard
Copy link
Contributor

Thanks for the report! Happy to see someone is using splom already!

@etpinard etpinard added the bug something broken label Apr 27, 2018
@jonmmease
Copy link
Contributor Author

Sure. And I'm super excited about the SPLOM trace!

@etpinard
Copy link
Contributor

etpinard commented May 1, 2018

Waiting on a reply in gl-vis/regl-splom#7

@etpinard
Copy link
Contributor

etpinard commented May 1, 2018

Fixed by #2593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

No branches or pull requests

2 participants