Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to esbuild for faster builds and also to allow using more modern JavaScript syntax and features #6909

Merged
merged 112 commits into from
Sep 12, 2024
Merged

Switch to esbuild for faster builds and also to allow using more modern JavaScript syntax and features #6909

merged 112 commits into from
Sep 12, 2024

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Feb 28, 2024 •
edited
Loading

@plotly/plotly_js

TODOs:

  • Fix regl_codegen
  • Fix custom bundles
  • Test new bundle in amdefine
  • Test new bundle in requirejs
  • Test new bundle in kaleido
  • Test new bundle in orca
  • additional QA on the python side on loading the bundle

alexcjohnson and others added 30 commits February 28, 2024 11:00
@alexcjohnson @archmoj
esbuild first cut
24876d8 
seems to work for everything except regl traces
@alexcjohnson @archmoj
put output name back to plotly.js
8d6d9ee
@archmoj
update package-lock diff
fd7e445
@archmoj
uninstall webpack
59af538
@archmoj
uninstall webpack-cli
9481fe5
@archmoj
uninstall node-polyfill-webpack-plugin
b70ad83
@archmoj
uninstall karma-webpack
ab7abd5
@archmoj
drop webpack from devtools/test_dashboard/server.mjs
63d3de8
@archmoj
remove webpack.config.js
55c03d8
@archmoj
install buffer
2b8d93a
@archmoj
install assert
cf5633e
@archmoj
rename devtools/regl_codegen/server from js to mjs
ca525fd
@archmoj
remove unused purgeGeneratedCode function
390b0f1
@archmoj
replace esbuild with webpack in devtools/regl_codegen/server
2a04743
@archmoj
rename tasks/bundle.js to tasks/bundle.mjs
0d6fd10
@archmoj
es6 imports in tasks/bundle.mjs
abc4532
@archmoj
bundle_wrapper.js > bundle_wrapper.mjs
687276a
@archmoj
rename cibundle.js & partial_bundle.js to .mjs
5701b7e
@archmoj
es6 import _bundle function
34f564e
@archmoj
replace webpack with esbuild in bundle_wrapper
80f0547
@archmoj
use esbuild to make bundles
ea7b866
@archmoj
rewrite custom_bundle and extra_bundles in es6
ad00767
@archmoj
js > mjs
c2c21d9
@archmoj
adjust export in partial_bundle.mjs
1ebbfad
@archmoj
do not provide sourcemap for now
a6d1437
@archmoj
fix bundle_wrapper
bf75f64
@archmoj
skip no-new-func test for now
1ccaec5
@archmoj
delete node12 tests
867ba0d
@archmoj
set minimum node16 in package.json
e2b52c6
@archmoj
update package-lock for node 16 minimum
d529e2a
@archmoj
Copy link
Contributor Author

archmoj commented Aug 22, 2024

@alexcjohnson @gvwilson
This PR is ready to go 🚀

@gvwilson
Copy link
Contributor

thank you - @marthacryan can you please have a look at this as well?

marthacryan
marthacryan reviewed Aug 22, 2024
View reviewed changes
CUSTOM_BUNDLE.md Outdated Show resolved Hide resolved
@archmoj
Copy link
Contributor Author

archmoj commented Aug 23, 2024 •
edited
Loading

I'm looking forward to @alexcjohnson's review on this as well. Also thanks to @marthacryan and @birkskyum reviews & contributions 🙏

This PR helps unblock Chart2Music keyboard and sound accessibility features in #6680. cc: @Coding-with-Adam

It might be a good idea and timing to include this in the upcoming RC release of [v2.35.0] (https://github.com/plotly/plotly.js/milestone/72) and our QA. cc: @gvwilson @ndrezn @LiamConnors

It would also help our ongoing and future development and testing of other pull requests. cc: @emilykl @antoinerg

@gvwilson
Copy link
Contributor

I approve. Let's hold off on the merge until next week (feels too big to do on a Friday), but congratulations everyone - well done.

@ndrezn
Copy link
Member

ndrezn commented Aug 23, 2024

Super excited about this! This change will really improve the development experience for Plotly.js. Kudos 🥳

@Coding-with-Adam
Copy link
Contributor

Wonderful news 🚀 . Thank you @archmoj; Thank you @marthacryan

alexcjohnson
alexcjohnson approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 I'm super excited for this. Looks great!

@archmoj
Copy link
Contributor Author

archmoj commented Aug 23, 2024

Thanks for the reviews!
Before merging this PR, I'd like to do additional QA on the python side on loading the bundle.

@archmoj archmoj modified the milestones: v2.35.0, v3.0.0 Aug 27, 2024
@birkskyum
Copy link
Contributor

birkskyum commented Sep 6, 2024 •
edited
Loading

We'll need to configure esbuild to also allow require(file.css) because of:

One option is here (esbuild-style-plugin), but there might be built-in support for this in esbuild:

birkskyum and others added 4 commits September 6, 2024 21:52
@birkskyum
Add .css loader to esbuild
b7189bd
@birkskyum
trailing comma
6275c72
@archmoj
Merge pull request #7142 from birkskyum/add-style-plugin
3328875 
Add .css loader to esbuild
@archmoj
Merge remote-tracking branch 'origin/master' into build-with-esbuild
53f896c 
 - Resolved conflicts in package-lock.json by copying lock file from master then npm install
@birkskyum birkskyum mentioned this pull request Sep 9, 2024
Open
@archmoj archmoj mentioned this pull request Sep 9, 2024
Merged
@archmoj archmoj merged commit bb2b8e6 into master Sep 12, 2024
1 check passed
@archmoj archmoj deleted the build-with-esbuild branch September 12, 2024 18:58
@archmoj archmoj mentioned this pull request Sep 23, 2024
Open
@marthacryan marthacryan mentioned this pull request Sep 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marthacryan marthacryan marthacryan left review comments

@birkskyum birkskyum birkskyum left review comments

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees

@archmoj archmoj

Labels
feature something new infrastructure build process etc. P1 needs immediate attention
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@archmoj @birkskyum @gvwilson @ndrezn @Coding-with-Adam @alexcjohnson @marthacryan