Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline.py blocks 'responsive' config key #1290

Closed
t-morley opened this issue Nov 29, 2018 · 1 comment · Fixed by #1377
Closed

offline.py blocks 'responsive' config key #1290

t-morley opened this issue Nov 29, 2018 · 1 comment · Fixed by #1377
Milestone

Comments

@t-morley
Copy link

Passing config = {'responsive': True} to offline.plot() does not have any effect.
This is because 'responsive' is not included in configkeys in _plot_html() in offline.py
Issue #907 reported other missing keys, which have now been added.
Since this could easily happen again, is there any way to automatically keep configkeys in step with the javascript?
Or could all provided keys be passed through, without filtering against configkeys, leaving it up to the user to get them right.
If there are bad consequences to passing invalid keys, so you want to keep the filtering by default, perhaps there could be an option on offline.plot() to allow the user to force keys through.

@jonmmease jonmmease added this to the v3.5.0 milestone Nov 30, 2018
@jonmmease
Copy link
Contributor

Thanks for the report @t-morley, we'll at least add in responsive key, but you're right that we should think about how to keep this from happening in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants