From b1a21d8fd6cddc8bfb81c64a3a0b9dc4835e3f92 Mon Sep 17 00:00:00 2001
From: Romain Lecouvreur <lecouvreurromain@gmail.com>
Date: Fri, 9 Feb 2024 14:26:45 +0100
Subject: [PATCH 1/9] Fix identical status label in simplified dashboard

---
 inc/formanswer.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
index 9fcde93f4..9dab052d0 100644
--- a/inc/formanswer.class.php
+++ b/inc/formanswer.class.php
@@ -75,7 +75,7 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
 
    public static function getStatuses() {
       return [
-         self::STATUS_WAITING  => __('Waiting', 'formcreator'),
+         self::STATUS_WAITING  => __('Waiting for approval'),
          self::STATUS_REFUSED  => __('Refused', 'formcreator'),
          self::STATUS_ACCEPTED => __('Accepted', 'formcreator'),
       ];

From d53bd4645b2ce3e43c66501a56aab5200bd333ce Mon Sep 17 00:00:00 2001
From: Romain Lecouvreur <lecouvreurromain@gmail.com>
Date: Fri, 9 Feb 2024 16:01:49 +0100
Subject: [PATCH 2/9] Change constant name from STATUS_WAITING to
 STATUS_APPROVAL

---
 inc/common.class.php                          |  2 +-
 inc/form.class.php                            |  6 ++--
 inc/formanswer.class.php                      | 28 +++++++++----------
 inc/issue.class.php                           |  8 +++---
 tests/3-unit/PluginFormcreatorCommon.php      |  2 +-
 tests/3-unit/PluginFormcreatorFormAnswer.php  |  2 +-
 tests/3-unit/PluginFormcreatorIssue.php       |  4 +--
 .../3-unit/PluginFormcreatorTargetTicket.php  | 10 +++----
 8 files changed, 31 insertions(+), 31 deletions(-)

diff --git a/inc/common.class.php b/inc/common.class.php
index 8174bf630..4d4fac7c3 100644
--- a/inc/common.class.php
+++ b/inc/common.class.php
@@ -274,7 +274,7 @@ public static function getTicketStatusForIssue(Ticket $item) : int {
          switch ($item->fields['global_validation']) {
             case CommonITILValidation::WAITING:
                if (!in_array($item->fields['status'], [Ticket::SOLVED, Ticket::CLOSED])) {
-                  $status = PluginFormcreatorFormAnswer::STATUS_WAITING;
+                  $status = PluginFormcreatorFormAnswer::STATUS_APPROVAL;
                }
                break;
             case CommonITILValidation::REFUSED:
diff --git a/inc/form.class.php b/inc/form.class.php
index 6ac380221..a9cb61c7c 100644
--- a/inc/form.class.php
+++ b/inc/form.class.php
@@ -126,7 +126,7 @@ public static function getMenuContent() {
                                  title="' . PluginFormcreatorIssue::getTypeName(Session::getPluralNumber()) . '"></i>';
 
       $menu['links']['search']          = PluginFormcreatorFormList::getSearchURL(false);
-      $menu['links'][$validation_image] = PluginFormcreatorFormAnswer::getSearchURL(false).'?criteria[0][link]=AND&criteria[0][field]=8&criteria[0][searchtype]=equals&criteria[0][value]=' . PluginFormcreatorFormAnswer::STATUS_WAITING;
+      $menu['links'][$validation_image] = PluginFormcreatorFormAnswer::getSearchURL(false).'?criteria[0][link]=AND&criteria[0][field]=8&criteria[0][searchtype]=equals&criteria[0][value]=' . PluginFormcreatorFormAnswer::STATUS_APPROVAL;
       $menu['links'][$import_image]     = PluginFormcreatorForm::getFormURL(false)."?import_form=1";
       $menu['links'][$requests_image]   = PluginFormcreatorIssue::getSearchURL(false);
       return $menu;
@@ -939,7 +939,7 @@ protected function showMyLastForms() : void {
          echo '<ul class="list-group">';
          foreach ($search['data']['rows'] as $formAnswer) {
             switch ($formAnswer['raw']["{$rawKeyBase}_8"]) {
-               case PluginFormcreatorFormAnswer::STATUS_WAITING:
+               case PluginFormcreatorFormAnswer::STATUS_APPROVAL:
                   $status = CommonITILObject::WAITING;
                   break;
                case PluginFormcreatorFormAnswer::STATUS_REFUSED:
@@ -1010,7 +1010,7 @@ protected function showMyLastForms() : void {
          echo '<ul class="list-group">';
          foreach ($search['data']['rows'] as $formAnswer) {
             switch ($formAnswer['raw']["{$rawKeyBase}_8"]) {
-               case PluginFormcreatorFormAnswer::STATUS_WAITING:
+               case PluginFormcreatorFormAnswer::STATUS_APPROVAL:
                   $status = CommonITILObject::WAITING;
                   break;
                case PluginFormcreatorFormAnswer::STATUS_REFUSED:
diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
index 9dab052d0..6320b6434 100644
--- a/inc/formanswer.class.php
+++ b/inc/formanswer.class.php
@@ -57,7 +57,7 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
 
    // Values choosen to not conflict with status of ticket constants
    // @see PluginFormcreatorIssue::getNewStatusArray
-   const STATUS_WAITING = 101;
+   const STATUS_APPROVAL = 101;
    const STATUS_REFUSED = 102;
    const STATUS_ACCEPTED = 103;
 
@@ -75,7 +75,7 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
 
    public static function getStatuses() {
       return [
-         self::STATUS_WAITING  => __('Waiting for approval'),
+         self::STATUS_APPROVAL  => __('Waiting for approval'),
          self::STATUS_REFUSED  => __('Refused', 'formcreator'),
          self::STATUS_ACCEPTED => __('Accepted', 'formcreator'),
       ];
@@ -361,7 +361,7 @@ public static function getSpecificValueToDisplay($field, $values, array $options
          case 'status' :
             if (!isAPI()) {
                switch ($values[$field]) {
-                  case PluginFormcreatorFormAnswer::STATUS_WAITING:
+                  case PluginFormcreatorFormAnswer::STATUS_APPROVAL:
                      $status = CommonITILObject::WAITING;
                      break;
                   case PluginFormcreatorFormAnswer::STATUS_REFUSED:
@@ -619,7 +619,7 @@ public function showForm($ID, $options = []) {
       // Can the current user edit the answers ?
       $canEdit = $this->fields['status'] == self::STATUS_REFUSED
          && Session::getLoginUserID() == $this->fields['requester_id']
-         || $this->fields['status'] == self::STATUS_WAITING
+         || $this->fields['status'] == self::STATUS_APPROVAL
          && $this->canValidate() && $editMode;
 
       // form title
@@ -727,7 +727,7 @@ public function showForm($ID, $options = []) {
          echo '</div>';
          echo '</div>';
 
-      } else if (($this->fields['status'] == self::STATUS_WAITING) && $this->canValidate()) {
+      } else if (($this->fields['status'] == self::STATUS_APPROVAL) && $this->canValidate()) {
          // Display validation form
          echo '<div class="form-group required line1">';
          echo '<label for="comment">' . __('Comment', 'formcreator') . ' <span class="red">*</span></label>';
@@ -873,7 +873,7 @@ public function prepareInputForUpdate($input) {
       }
 
       $skipValidation = false;
-      $input['status'] = self::STATUS_WAITING;
+      $input['status'] = self::STATUS_APPROVAL;
       if (isset($input['refuse_formanswer']) || isset($input['accept_formanswer'])) {
          // The formanswer is being acepted or refused
 
@@ -1238,7 +1238,7 @@ public function post_addItem() {
 
             // TODO: find a way to validate the answers
             // It the form is not being validated, nothing gives the power to anyone to validate the answers
-            $formAnswer->updateStatus(self::STATUS_WAITING);
+            $formAnswer->updateStatus(self::STATUS_APPROVAL);
             return;
          }
       }
@@ -1290,7 +1290,7 @@ public function post_updateItem($history = 1) {
 
             // TODO: find a way to validate the answers
             // If the form is not being validated, nothing gives the power to anyone to validate the answers
-            $this->updateStatus(self::STATUS_WAITING);
+            $this->updateStatus(self::STATUS_APPROVAL);
             return;
          }
       }
@@ -1319,7 +1319,7 @@ public function post_purgeItem() {
       );
 
       // If the form was waiting for validation
-      if ($this->fields['status'] == self::STATUS_WAITING) {
+      if ($this->fields['status'] == self::STATUS_APPROVAL) {
          // Notify the requester
          NotificationEvent::raiseEvent('plugin_formcreator_deleted', $this);
       }
@@ -1503,7 +1503,7 @@ protected function validateValidator(array $input): bool {
 
    private function sendNotification() {
       switch ($this->input['status']) {
-         case self::STATUS_WAITING :
+         case self::STATUS_APPROVAL :
             // Notify the requester
             NotificationEvent::raiseEvent('plugin_formcreator_form_created', $this);
             // Notify the validator
@@ -1803,7 +1803,7 @@ protected function setValidator(array $input): array {
                   // The requester is the validator. No need to validate
                   break;
                }
-               $input['status'] = self::STATUS_WAITING;
+               $input['status'] = self::STATUS_APPROVAL;
                break;
 
             case PluginFormcreatorForm::VALIDATION_GROUP:
@@ -1816,7 +1816,7 @@ protected function setValidator(array $input): array {
                   // The requester is a member of the validator group
                   break;
                }
-               $input['status'] = self::STATUS_WAITING;
+               $input['status'] = self::STATUS_APPROVAL;
                break;
          }
       }
@@ -1919,7 +1919,7 @@ public function getApprovers(array $crit = []): ?array {
     * @return array|null
     */
    public function getCurrentApprovers(): ?array {
-      if ($this->fields['status'] != self::STATUS_WAITING) {
+      if ($this->fields['status'] != self::STATUS_APPROVAL) {
          return null;
       }
 
@@ -2003,7 +2003,7 @@ public function getAggregatedStatus(): ?int {
             continue;
          }
          $ticketStatus = PluginFormcreatorCommon::getTicketStatusForIssue($generatedTarget);
-         if ($ticketStatus >= PluginFormcreatorFormAnswer::STATUS_WAITING) {
+         if ($ticketStatus >= PluginFormcreatorFormAnswer::STATUS_APPROVAL) {
             // Ignore tickets refused or pending for validation
             // getTicketStatusForIssue() does not returns STATUS_ACCEPTED
             continue;
diff --git a/inc/issue.class.php b/inc/issue.class.php
index b1d6044f2..1e81956d9 100644
--- a/inc/issue.class.php
+++ b/inc/issue.class.php
@@ -148,7 +148,7 @@ public static function getSyncIssuesRequest() : AbstractQuery {
                IF(`$ticketTable`.`status` IN ('" . CommonITILObject::SOLVED . "', '" . CommonITILObject::CLOSED . "'),
                   `$ticketTable`.`status`,
                   IF(`$ticketTable`.`global_validation` = '" . CommonITILValidation::WAITING . "',
-                     '" . PluginFormcreatorFormAnswer::STATUS_WAITING . "',
+                     '" . PluginFormcreatorFormAnswer::STATUS_APPROVAL . "',
                      '" . PluginFormcreatorFormAnswer::STATUS_REFUSED . "'
                   )
                )
@@ -1134,7 +1134,7 @@ static function getNewStatusArray() {
    }
 
    static function getPendingStatusArray() {
-      return [Ticket::WAITING, PluginFormcreatorFormAnswer::STATUS_WAITING];
+      return [Ticket::WAITING, PluginFormcreatorFormAnswer::STATUS_APPROVAL];
    }
 
    static function getProcessStatusArray() {
@@ -1147,7 +1147,7 @@ static function getReopenableStatusArray() {
 
    static function getAllStatusArray($withmetaforsearch = false) {
       $ticket_status = Ticket::getAllStatusArray($withmetaforsearch);
-      $form_status = [PluginFormcreatorFormAnswer::STATUS_WAITING, PluginFormcreatorFormAnswer::STATUS_ACCEPTED, PluginFormcreatorFormAnswer::STATUS_REFUSED];
+      $form_status = [PluginFormcreatorFormAnswer::STATUS_APPROVAL, PluginFormcreatorFormAnswer::STATUS_ACCEPTED, PluginFormcreatorFormAnswer::STATUS_REFUSED];
       $form_status = array_combine($form_status, $form_status);
       $all_status = $ticket_status + $form_status;
       return $all_status;
@@ -1189,7 +1189,7 @@ static function getValidateCriteria() {
       return ['criteria' => [['link'       => 'AND',
                               'field' => 4,
                               'searchtype' => 'equals',
-                              'value'      => PluginFormcreatorFormAnswer::STATUS_WAITING,
+                              'value'      => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
                               ],
                             ],
               'reset'    => 'reset'];
diff --git a/tests/3-unit/PluginFormcreatorCommon.php b/tests/3-unit/PluginFormcreatorCommon.php
index 7ac5daeb5..f204b1215 100644
--- a/tests/3-unit/PluginFormcreatorCommon.php
+++ b/tests/3-unit/PluginFormcreatorCommon.php
@@ -295,7 +295,7 @@ public function providerGetTicketStatusForIssue() {
          $ticket->fields['global_validation'] = \CommonITILValidation::WAITING;
          $dataSet = [
             'ticket' => $ticket,
-            'expected' => \PluginFormcreatorFormAnswer::STATUS_WAITING
+            'expected' => \PluginFormcreatorFormAnswer::STATUS_APPROVAL
          ];
          yield $dataSet;
       }
diff --git a/tests/3-unit/PluginFormcreatorFormAnswer.php b/tests/3-unit/PluginFormcreatorFormAnswer.php
index 3c39942c2..03b8f4e53 100644
--- a/tests/3-unit/PluginFormcreatorFormAnswer.php
+++ b/tests/3-unit/PluginFormcreatorFormAnswer.php
@@ -142,7 +142,7 @@ public function providerPrepareInputForAdd() {
             'formcreator_validator'                   => $user::getType() . '_' . $user->getID(),
             'users_id_validator'                      => $user->getID(),
             'groups_id_validator'                     => 0,
-            'status'                                  => $testedClassName::STATUS_WAITING,
+            'status'                                  => $testedClassName::STATUS_APPROVAL,
             'request_date'                            => $_SESSION['glpi_currenttime'],
             'comment'                                 => '',
          ],
diff --git a/tests/3-unit/PluginFormcreatorIssue.php b/tests/3-unit/PluginFormcreatorIssue.php
index 075657513..0e9cd07ed 100644
--- a/tests/3-unit/PluginFormcreatorIssue.php
+++ b/tests/3-unit/PluginFormcreatorIssue.php
@@ -340,7 +340,7 @@ public function providerGetsyncIssuesRequest_ticketUnderValidation() {
                'items_id'      => $ticket->getID(),
                'display_id'    => 't_' . $ticket->getID(),
                'name'          => $ticket->fields['name'],
-               'status'        => PluginFormcreatorFormAnswer::STATUS_WAITING,
+               'status'        => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
                'requester_id'  => $ticket->fields['users_id_recipient'],
                'date_creation' => $ticket->fields['date'],
                'date_mod'      => $ticket->fields['date_mod'],
@@ -422,7 +422,7 @@ public function providerGetsyncIssuesRequest_validatedTicket() {
                'items_id'      => $ticket2->getID(),
                'display_id'    => 't_' . $ticket2->getID(),
                'name'          => $ticket2->fields['name'],
-               'status'        => PluginFormcreatorFormAnswer::STATUS_WAITING,
+               'status'        => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
                'requester_id'  => $ticket2->fields['users_id_recipient'],
                'date_creation' => $ticket2->fields['date'],
                'date_mod'      => $ticket2->fields['date_mod'],
diff --git a/tests/3-unit/PluginFormcreatorTargetTicket.php b/tests/3-unit/PluginFormcreatorTargetTicket.php
index 479fe8d79..2c0a528fb 100644
--- a/tests/3-unit/PluginFormcreatorTargetTicket.php
+++ b/tests/3-unit/PluginFormcreatorTargetTicket.php
@@ -553,7 +553,7 @@ public function providerSetTargetType() {
                PluginFormcreatorForm::getForeignKeyField() => $form1->getID(),
                'name' => $form1->fields['name'],
                'requester_id' => 2, // glpi user id
-               'status' => PluginFormcreatorFormAnswer::STATUS_WAITING,
+               'status' => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
                'formcreator_validator' => 2, // Glpi user ID
                'formcreator_field_' . $question1->getID() => (string) Ticket::INCIDENT_TYPE,
             ]),
@@ -565,7 +565,7 @@ public function providerSetTargetType() {
                PluginFormcreatorForm::getForeignKeyField() => $form1->getID(),
                'name' => $form1->fields['name'],
                'requester_id' => 2, // glpi user id
-               'status' => PluginFormcreatorFormAnswer::STATUS_WAITING,
+               'status' => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
                'formcreator_validator' => 2, // Glpi user ID
                'formcreator_field_' . $question1->getID() => (string) Ticket::DEMAND_TYPE,
             ]),
@@ -577,7 +577,7 @@ public function providerSetTargetType() {
                PluginFormcreatorForm::getForeignKeyField() => $form2->getID(),
                'name' => $form2->fields['name'],
                'requester_id' => 2, // glpi user id
-               'status' => PluginFormcreatorFormAnswer::STATUS_WAITING,
+               'status' => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
                'formcreator_validator' => 2, // Glpi user ID
                'formcreator_field_' . $question2->getID() => (string) Ticket::DEMAND_TYPE,
             ]),
@@ -589,7 +589,7 @@ public function providerSetTargetType() {
                PluginFormcreatorForm::getForeignKeyField() => $form2->getID(),
                'name' => $form2->fields['name'],
                'requester_id' => 2, // glpi user id
-               'status' => PluginFormcreatorFormAnswer::STATUS_WAITING,
+               'status' => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
                'formcreator_validator' => 2, // Glpi user ID
                'formcreator_field_' . $question2->getID() => (string) Ticket::INCIDENT_TYPE,
             ]),
@@ -1100,7 +1100,7 @@ public function providerSetTargetAssociatedItem_1() {
          PluginFormcreatorForm::getForeignKeyField() => $form->getID(),
          'name' => $form->fields['name'],
          'requester_d' => 2, // glpi user id
-         'status' => PluginFormcreatorFormAnswer::STATUS_WAITING,
+         'status' => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
          'formcreator_field_' . $question->getID() => (string) $computer->getID(),
       ]);
       $this->boolean($formAnswer->isNewItem())->isFalse();

From 431ef0cdb80c9f9fb019079e6bea860dbf4634e1 Mon Sep 17 00:00:00 2001
From: Romain Lecouvreur <lecouvreurromain@gmail.com>
Date: Fri, 9 Feb 2024 16:37:07 +0100
Subject: [PATCH 3/9] Add constant name WAITING_APPROVAL

---
 inc/common.class.php                         |  2 +-
 inc/form.class.php                           |  2 +-
 inc/formanswer.class.php                     | 10 ++++++----
 inc/issue.class.php                          |  4 ++--
 tests/3-unit/PluginFormcreatorCommon.php     |  2 +-
 tests/3-unit/PluginFormcreatorFormAnswer.php |  2 +-
 tests/3-unit/PluginFormcreatorIssue.php      |  4 ++--
 7 files changed, 14 insertions(+), 12 deletions(-)

diff --git a/inc/common.class.php b/inc/common.class.php
index 8174bf630..4683d4a5c 100644
--- a/inc/common.class.php
+++ b/inc/common.class.php
@@ -274,7 +274,7 @@ public static function getTicketStatusForIssue(Ticket $item) : int {
          switch ($item->fields['global_validation']) {
             case CommonITILValidation::WAITING:
                if (!in_array($item->fields['status'], [Ticket::SOLVED, Ticket::CLOSED])) {
-                  $status = PluginFormcreatorFormAnswer::STATUS_WAITING;
+                  $status = PluginFormcreatorFormAnswer::WAITING_APPROVAL;
                }
                break;
             case CommonITILValidation::REFUSED:
diff --git a/inc/form.class.php b/inc/form.class.php
index 6ac380221..574af19d3 100644
--- a/inc/form.class.php
+++ b/inc/form.class.php
@@ -126,7 +126,7 @@ public static function getMenuContent() {
                                  title="' . PluginFormcreatorIssue::getTypeName(Session::getPluralNumber()) . '"></i>';
 
       $menu['links']['search']          = PluginFormcreatorFormList::getSearchURL(false);
-      $menu['links'][$validation_image] = PluginFormcreatorFormAnswer::getSearchURL(false).'?criteria[0][link]=AND&criteria[0][field]=8&criteria[0][searchtype]=equals&criteria[0][value]=' . PluginFormcreatorFormAnswer::STATUS_WAITING;
+      $menu['links'][$validation_image] = PluginFormcreatorFormAnswer::getSearchURL(false).'?criteria[0][link]=AND&criteria[0][field]=8&criteria[0][searchtype]=equals&criteria[0][value]=' . PluginFormcreatorFormAnswer::WAITING_APPROVAL;
       $menu['links'][$import_image]     = PluginFormcreatorForm::getFormURL(false)."?import_form=1";
       $menu['links'][$requests_image]   = PluginFormcreatorIssue::getSearchURL(false);
       return $menu;
diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
index 9dab052d0..273becbe6 100644
--- a/inc/formanswer.class.php
+++ b/inc/formanswer.class.php
@@ -57,6 +57,7 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
 
    // Values choosen to not conflict with status of ticket constants
    // @see PluginFormcreatorIssue::getNewStatusArray
+   const WAITING_APPROVAL = 101;
    const STATUS_WAITING = 101;
    const STATUS_REFUSED = 102;
    const STATUS_ACCEPTED = 103;
@@ -75,9 +76,10 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
 
    public static function getStatuses() {
       return [
-         self::STATUS_WAITING  => __('Waiting for approval'),
-         self::STATUS_REFUSED  => __('Refused', 'formcreator'),
-         self::STATUS_ACCEPTED => __('Accepted', 'formcreator'),
+         self::WAITING_APPROVAL  => __('Waiting for approval'),
+         self::STATUS_WAITING    => __('Waiting', 'formcreator'),
+         self::STATUS_REFUSED    => __('Refused', 'formcreator'),
+         self::STATUS_ACCEPTED   => __('Accepted', 'formcreator'),
       ];
    }
 
@@ -1914,7 +1916,7 @@ public function getApprovers(array $crit = []): ?array {
    }
 
    /**
-    * Get users or groupe in charge of valdiation
+    * Get users or groupe in charge of validation
     *
     * @return array|null
     */
diff --git a/inc/issue.class.php b/inc/issue.class.php
index b1d6044f2..4828c2a2e 100644
--- a/inc/issue.class.php
+++ b/inc/issue.class.php
@@ -148,7 +148,7 @@ public static function getSyncIssuesRequest() : AbstractQuery {
                IF(`$ticketTable`.`status` IN ('" . CommonITILObject::SOLVED . "', '" . CommonITILObject::CLOSED . "'),
                   `$ticketTable`.`status`,
                   IF(`$ticketTable`.`global_validation` = '" . CommonITILValidation::WAITING . "',
-                     '" . PluginFormcreatorFormAnswer::STATUS_WAITING . "',
+                     '" . PluginFormcreatorFormAnswer::WAITING_APPROVAL . "',
                      '" . PluginFormcreatorFormAnswer::STATUS_REFUSED . "'
                   )
                )
@@ -1189,7 +1189,7 @@ static function getValidateCriteria() {
       return ['criteria' => [['link'       => 'AND',
                               'field' => 4,
                               'searchtype' => 'equals',
-                              'value'      => PluginFormcreatorFormAnswer::STATUS_WAITING,
+                              'value'      => PluginFormcreatorFormAnswer::WAITING_APPROVAL,
                               ],
                             ],
               'reset'    => 'reset'];
diff --git a/tests/3-unit/PluginFormcreatorCommon.php b/tests/3-unit/PluginFormcreatorCommon.php
index 7ac5daeb5..6688fab76 100644
--- a/tests/3-unit/PluginFormcreatorCommon.php
+++ b/tests/3-unit/PluginFormcreatorCommon.php
@@ -295,7 +295,7 @@ public function providerGetTicketStatusForIssue() {
          $ticket->fields['global_validation'] = \CommonITILValidation::WAITING;
          $dataSet = [
             'ticket' => $ticket,
-            'expected' => \PluginFormcreatorFormAnswer::STATUS_WAITING
+            'expected' => \PluginFormcreatorFormAnswer::WAITING_APPROVAL
          ];
          yield $dataSet;
       }
diff --git a/tests/3-unit/PluginFormcreatorFormAnswer.php b/tests/3-unit/PluginFormcreatorFormAnswer.php
index 3c39942c2..9ad10c0f0 100644
--- a/tests/3-unit/PluginFormcreatorFormAnswer.php
+++ b/tests/3-unit/PluginFormcreatorFormAnswer.php
@@ -142,7 +142,7 @@ public function providerPrepareInputForAdd() {
             'formcreator_validator'                   => $user::getType() . '_' . $user->getID(),
             'users_id_validator'                      => $user->getID(),
             'groups_id_validator'                     => 0,
-            'status'                                  => $testedClassName::STATUS_WAITING,
+            'status'                                  => $testedClassName::WAITING_APPROVAL,
             'request_date'                            => $_SESSION['glpi_currenttime'],
             'comment'                                 => '',
          ],
diff --git a/tests/3-unit/PluginFormcreatorIssue.php b/tests/3-unit/PluginFormcreatorIssue.php
index 075657513..ef5af9104 100644
--- a/tests/3-unit/PluginFormcreatorIssue.php
+++ b/tests/3-unit/PluginFormcreatorIssue.php
@@ -340,7 +340,7 @@ public function providerGetsyncIssuesRequest_ticketUnderValidation() {
                'items_id'      => $ticket->getID(),
                'display_id'    => 't_' . $ticket->getID(),
                'name'          => $ticket->fields['name'],
-               'status'        => PluginFormcreatorFormAnswer::STATUS_WAITING,
+               'status'        => PluginFormcreatorFormAnswer::WAITING_APPROVAL,
                'requester_id'  => $ticket->fields['users_id_recipient'],
                'date_creation' => $ticket->fields['date'],
                'date_mod'      => $ticket->fields['date_mod'],
@@ -422,7 +422,7 @@ public function providerGetsyncIssuesRequest_validatedTicket() {
                'items_id'      => $ticket2->getID(),
                'display_id'    => 't_' . $ticket2->getID(),
                'name'          => $ticket2->fields['name'],
-               'status'        => PluginFormcreatorFormAnswer::STATUS_WAITING,
+               'status'        => PluginFormcreatorFormAnswer::WAITING_APPROVAL,
                'requester_id'  => $ticket2->fields['users_id_recipient'],
                'date_creation' => $ticket2->fields['date'],
                'date_mod'      => $ticket2->fields['date_mod'],

From 3f31414d6cb1c8ffc07507367f99860af1badfa6 Mon Sep 17 00:00:00 2001
From: Romain Lecouvreur <102067890+RomainLvr@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:52:22 +0100
Subject: [PATCH 4/9] Fix failed unit tests

---
 inc/formanswer.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
index f79128668..e282b1529 100644
--- a/inc/formanswer.class.php
+++ b/inc/formanswer.class.php
@@ -1505,7 +1505,7 @@ protected function validateValidator(array $input): bool {
 
    private function sendNotification() {
       switch ($this->input['status']) {
-         case self::STATUS_APPROVAL :
+         case self::STATUS_WAITING :
             // Notify the requester
             NotificationEvent::raiseEvent('plugin_formcreator_form_created', $this);
             // Notify the validator

From df46fa692a6e3121624eb278e046573fb21002a5 Mon Sep 17 00:00:00 2001
From: Romain Lecouvreur <102067890+RomainLvr@users.noreply.github.com>
Date: Fri, 9 Feb 2024 17:57:08 +0100
Subject: [PATCH 5/9] Fix failed unit tests

---
 inc/formanswer.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
index e282b1529..a52651f54 100644
--- a/inc/formanswer.class.php
+++ b/inc/formanswer.class.php
@@ -363,7 +363,7 @@ public static function getSpecificValueToDisplay($field, $values, array $options
          case 'status' :
             if (!isAPI()) {
                switch ($values[$field]) {
-                  case PluginFormcreatorFormAnswer::STATUS_APPROVAL:
+                  case PluginFormcreatorFormAnswer::STATUS_WAITING:
                      $status = CommonITILObject::WAITING;
                      break;
                   case PluginFormcreatorFormAnswer::STATUS_REFUSED:

From 6c66fd60099e439b1eb4877aec57e76feb2e81ae Mon Sep 17 00:00:00 2001
From: Romain Lecouvreur <102067890+RomainLvr@users.noreply.github.com>
Date: Fri, 9 Feb 2024 18:09:29 +0100
Subject: [PATCH 6/9] Fix failed unit tests

---
 inc/formanswer.class.php | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
index a52651f54..273becbe6 100644
--- a/inc/formanswer.class.php
+++ b/inc/formanswer.class.php
@@ -621,7 +621,7 @@ public function showForm($ID, $options = []) {
       // Can the current user edit the answers ?
       $canEdit = $this->fields['status'] == self::STATUS_REFUSED
          && Session::getLoginUserID() == $this->fields['requester_id']
-         || $this->fields['status'] == self::STATUS_APPROVAL
+         || $this->fields['status'] == self::STATUS_WAITING
          && $this->canValidate() && $editMode;
 
       // form title
@@ -729,7 +729,7 @@ public function showForm($ID, $options = []) {
          echo '</div>';
          echo '</div>';
 
-      } else if (($this->fields['status'] == self::STATUS_APPROVAL) && $this->canValidate()) {
+      } else if (($this->fields['status'] == self::STATUS_WAITING) && $this->canValidate()) {
          // Display validation form
          echo '<div class="form-group required line1">';
          echo '<label for="comment">' . __('Comment', 'formcreator') . ' <span class="red">*</span></label>';
@@ -875,7 +875,7 @@ public function prepareInputForUpdate($input) {
       }
 
       $skipValidation = false;
-      $input['status'] = self::STATUS_APPROVAL;
+      $input['status'] = self::STATUS_WAITING;
       if (isset($input['refuse_formanswer']) || isset($input['accept_formanswer'])) {
          // The formanswer is being acepted or refused
 
@@ -1240,7 +1240,7 @@ public function post_addItem() {
 
             // TODO: find a way to validate the answers
             // It the form is not being validated, nothing gives the power to anyone to validate the answers
-            $formAnswer->updateStatus(self::STATUS_APPROVAL);
+            $formAnswer->updateStatus(self::STATUS_WAITING);
             return;
          }
       }
@@ -1292,7 +1292,7 @@ public function post_updateItem($history = 1) {
 
             // TODO: find a way to validate the answers
             // If the form is not being validated, nothing gives the power to anyone to validate the answers
-            $this->updateStatus(self::STATUS_APPROVAL);
+            $this->updateStatus(self::STATUS_WAITING);
             return;
          }
       }
@@ -1321,7 +1321,7 @@ public function post_purgeItem() {
       );
 
       // If the form was waiting for validation
-      if ($this->fields['status'] == self::STATUS_APPROVAL) {
+      if ($this->fields['status'] == self::STATUS_WAITING) {
          // Notify the requester
          NotificationEvent::raiseEvent('plugin_formcreator_deleted', $this);
       }
@@ -1805,7 +1805,7 @@ protected function setValidator(array $input): array {
                   // The requester is the validator. No need to validate
                   break;
                }
-               $input['status'] = self::STATUS_APPROVAL;
+               $input['status'] = self::STATUS_WAITING;
                break;
 
             case PluginFormcreatorForm::VALIDATION_GROUP:
@@ -1818,7 +1818,7 @@ protected function setValidator(array $input): array {
                   // The requester is a member of the validator group
                   break;
                }
-               $input['status'] = self::STATUS_APPROVAL;
+               $input['status'] = self::STATUS_WAITING;
                break;
          }
       }
@@ -1921,7 +1921,7 @@ public function getApprovers(array $crit = []): ?array {
     * @return array|null
     */
    public function getCurrentApprovers(): ?array {
-      if ($this->fields['status'] != self::STATUS_APPROVAL) {
+      if ($this->fields['status'] != self::STATUS_WAITING) {
          return null;
       }
 
@@ -2005,7 +2005,7 @@ public function getAggregatedStatus(): ?int {
             continue;
          }
          $ticketStatus = PluginFormcreatorCommon::getTicketStatusForIssue($generatedTarget);
-         if ($ticketStatus >= PluginFormcreatorFormAnswer::STATUS_APPROVAL) {
+         if ($ticketStatus >= PluginFormcreatorFormAnswer::STATUS_WAITING) {
             // Ignore tickets refused or pending for validation
             // getTicketStatusForIssue() does not returns STATUS_ACCEPTED
             continue;

From 6e83e7b4070d7e718869ac5929b8b57c092686b9 Mon Sep 17 00:00:00 2001
From: RomainLvr <lecouvreurromain@gmail.com>
Date: Fri, 12 Apr 2024 13:49:30 +0200
Subject: [PATCH 7/9] Fix mistakes

---
 inc/form.class.php                           | 2 +-
 inc/formanswer.class.php                     | 4 ++--
 inc/issue.class.php                          | 6 +++---
 tests/3-unit/PluginFormcreatorCommon.php     | 2 +-
 tests/3-unit/PluginFormcreatorFormAnswer.php | 2 +-
 tests/3-unit/PluginFormcreatorIssue.php      | 4 ++--
 6 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/inc/form.class.php b/inc/form.class.php
index 574af19d3..54f93a90b 100644
--- a/inc/form.class.php
+++ b/inc/form.class.php
@@ -126,7 +126,7 @@ public static function getMenuContent() {
                                  title="' . PluginFormcreatorIssue::getTypeName(Session::getPluralNumber()) . '"></i>';
 
       $menu['links']['search']          = PluginFormcreatorFormList::getSearchURL(false);
-      $menu['links'][$validation_image] = PluginFormcreatorFormAnswer::getSearchURL(false).'?criteria[0][link]=AND&criteria[0][field]=8&criteria[0][searchtype]=equals&criteria[0][value]=' . PluginFormcreatorFormAnswer::WAITING_APPROVAL;
+      $menu['links'][$validation_image] = PluginFormcreatorFormAnswer::getSearchURL(false).'?criteria[0][link]=AND&criteria[0][field]=8&criteria[0][searchtype]=equals&criteria[0][value]=' . PluginFormcreatorFormAnswer::STATUS_APPROVAL;
       $menu['links'][$import_image]     = PluginFormcreatorForm::getFormURL(false)."?import_form=1";
       $menu['links'][$requests_image]   = PluginFormcreatorIssue::getSearchURL(false);
       return $menu;
diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
index 273becbe6..d3417492e 100644
--- a/inc/formanswer.class.php
+++ b/inc/formanswer.class.php
@@ -57,7 +57,7 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
 
    // Values choosen to not conflict with status of ticket constants
    // @see PluginFormcreatorIssue::getNewStatusArray
-   const WAITING_APPROVAL = 101;
+   const STATUS_APPROVAL = 101;
    const STATUS_WAITING = 101;
    const STATUS_REFUSED = 102;
    const STATUS_ACCEPTED = 103;
@@ -76,7 +76,7 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
 
    public static function getStatuses() {
       return [
-         self::WAITING_APPROVAL  => __('Waiting for approval'),
+         self::STATUS_APPROVAL  => __('Waiting for approval'),
          self::STATUS_WAITING    => __('Waiting', 'formcreator'),
          self::STATUS_REFUSED    => __('Refused', 'formcreator'),
          self::STATUS_ACCEPTED   => __('Accepted', 'formcreator'),
diff --git a/inc/issue.class.php b/inc/issue.class.php
index a282ae646..fa1e49ff7 100644
--- a/inc/issue.class.php
+++ b/inc/issue.class.php
@@ -148,7 +148,7 @@ public static function getSyncIssuesRequest() : AbstractQuery {
                IF(`$ticketTable`.`status` IN ('" . CommonITILObject::SOLVED . "', '" . CommonITILObject::CLOSED . "'),
                   `$ticketTable`.`status`,
                   IF(`$ticketTable`.`global_validation` = '" . CommonITILValidation::WAITING . "',
-                     '" . PluginFormcreatorFormAnswer::WAITING_APPROVAL . "',
+                     '" . PluginFormcreatorFormAnswer::STATUS_APPROVAL . "',
                      '" . PluginFormcreatorFormAnswer::STATUS_REFUSED . "'
                   )
                )
@@ -1147,7 +1147,7 @@ static function getReopenableStatusArray() {
 
    static function getAllStatusArray($withmetaforsearch = false) {
       $ticket_status = Ticket::getAllStatusArray($withmetaforsearch);
-      $form_status = [PluginFormcreatorFormAnswer::STATUS_APPROVAL, PluginFormcreatorFormAnswer::STATUS_ACCEPTED, PluginFormcreatorFormAnswer::STATUS_REFUSED];
+      $form_status = [PluginFormcreatorFormAnswer::STATUS_APPROVAL, PluginFormcreatorFormAnswer::STATUS_WAITING, PluginFormcreatorFormAnswer::STATUS_ACCEPTED, PluginFormcreatorFormAnswer::STATUS_REFUSED];
       $form_status = array_combine($form_status, $form_status);
       $all_status = $ticket_status + $form_status;
       return $all_status;
@@ -1189,7 +1189,7 @@ static function getValidateCriteria() {
       return ['criteria' => [['link'       => 'AND',
                               'field' => 4,
                               'searchtype' => 'equals',
-                              'value'      => PluginFormcreatorFormAnswer::WAITING_APPROVAL,
+                              'value'      => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
                               ],
                             ],
               'reset'    => 'reset'];
diff --git a/tests/3-unit/PluginFormcreatorCommon.php b/tests/3-unit/PluginFormcreatorCommon.php
index 6688fab76..f204b1215 100644
--- a/tests/3-unit/PluginFormcreatorCommon.php
+++ b/tests/3-unit/PluginFormcreatorCommon.php
@@ -295,7 +295,7 @@ public function providerGetTicketStatusForIssue() {
          $ticket->fields['global_validation'] = \CommonITILValidation::WAITING;
          $dataSet = [
             'ticket' => $ticket,
-            'expected' => \PluginFormcreatorFormAnswer::WAITING_APPROVAL
+            'expected' => \PluginFormcreatorFormAnswer::STATUS_APPROVAL
          ];
          yield $dataSet;
       }
diff --git a/tests/3-unit/PluginFormcreatorFormAnswer.php b/tests/3-unit/PluginFormcreatorFormAnswer.php
index 9ad10c0f0..03b8f4e53 100644
--- a/tests/3-unit/PluginFormcreatorFormAnswer.php
+++ b/tests/3-unit/PluginFormcreatorFormAnswer.php
@@ -142,7 +142,7 @@ public function providerPrepareInputForAdd() {
             'formcreator_validator'                   => $user::getType() . '_' . $user->getID(),
             'users_id_validator'                      => $user->getID(),
             'groups_id_validator'                     => 0,
-            'status'                                  => $testedClassName::WAITING_APPROVAL,
+            'status'                                  => $testedClassName::STATUS_APPROVAL,
             'request_date'                            => $_SESSION['glpi_currenttime'],
             'comment'                                 => '',
          ],
diff --git a/tests/3-unit/PluginFormcreatorIssue.php b/tests/3-unit/PluginFormcreatorIssue.php
index ef5af9104..0e9cd07ed 100644
--- a/tests/3-unit/PluginFormcreatorIssue.php
+++ b/tests/3-unit/PluginFormcreatorIssue.php
@@ -340,7 +340,7 @@ public function providerGetsyncIssuesRequest_ticketUnderValidation() {
                'items_id'      => $ticket->getID(),
                'display_id'    => 't_' . $ticket->getID(),
                'name'          => $ticket->fields['name'],
-               'status'        => PluginFormcreatorFormAnswer::WAITING_APPROVAL,
+               'status'        => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
                'requester_id'  => $ticket->fields['users_id_recipient'],
                'date_creation' => $ticket->fields['date'],
                'date_mod'      => $ticket->fields['date_mod'],
@@ -422,7 +422,7 @@ public function providerGetsyncIssuesRequest_validatedTicket() {
                'items_id'      => $ticket2->getID(),
                'display_id'    => 't_' . $ticket2->getID(),
                'name'          => $ticket2->fields['name'],
-               'status'        => PluginFormcreatorFormAnswer::WAITING_APPROVAL,
+               'status'        => PluginFormcreatorFormAnswer::STATUS_APPROVAL,
                'requester_id'  => $ticket2->fields['users_id_recipient'],
                'date_creation' => $ticket2->fields['date'],
                'date_mod'      => $ticket2->fields['date_mod'],

From 17a407485ec9db8df3213d28fc465f2518ec929f Mon Sep 17 00:00:00 2001
From: RomainLvr <lecouvreurromain@gmail.com>
Date: Mon, 2 Sep 2024 12:20:12 +0200
Subject: [PATCH 8/9] Remove duplicate constant value

---
 inc/formanswer.class.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
index d3417492e..4d65dc14e 100644
--- a/inc/formanswer.class.php
+++ b/inc/formanswer.class.php
@@ -57,7 +57,7 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
 
    // Values choosen to not conflict with status of ticket constants
    // @see PluginFormcreatorIssue::getNewStatusArray
-   const STATUS_APPROVAL = 101;
+   const STATUS_APPROVAL = 100;
    const STATUS_WAITING = 101;
    const STATUS_REFUSED = 102;
    const STATUS_ACCEPTED = 103;

From a14707bb05bc7a5a8c0d9bad1dd2a406611db619 Mon Sep 17 00:00:00 2001
From: RomainLvr <lecouvreurromain@gmail.com>
Date: Mon, 2 Sep 2024 16:18:55 +0200
Subject: [PATCH 9/9] Swap constants values

---
 inc/formanswer.class.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/inc/formanswer.class.php b/inc/formanswer.class.php
index 4d65dc14e..cf98500dc 100644
--- a/inc/formanswer.class.php
+++ b/inc/formanswer.class.php
@@ -57,8 +57,8 @@ class PluginFormcreatorFormAnswer extends CommonDBTM
 
    // Values choosen to not conflict with status of ticket constants
    // @see PluginFormcreatorIssue::getNewStatusArray
-   const STATUS_APPROVAL = 100;
-   const STATUS_WAITING = 101;
+   const STATUS_WAITING = 100;
+   const STATUS_APPROVAL = 101;
    const STATUS_REFUSED = 102;
    const STATUS_ACCEPTED = 103;