Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning no error on ulog check fail #5993

Open
janekmi opened this issue Jan 31, 2024 · 0 comments
Open

Returning no error on ulog check fail #5993

janekmi opened this issue Jan 31, 2024 · 0 comments
Labels
libpmemobj src/libpmemobj Priority: 2 high Type: Bug A previously unknown bug in PMDK
Milestone

Comments

@janekmi
Copy link
Contributor

janekmi commented Jan 31, 2024

int
lane_check(PMEMobjpool *pop)
{
	int err = 0;
	/* ... */
	for (j = 0; j < pop->nlanes; ++j) {
		/* ... */
		if (ulog_check(/* ... */) != 0) {
			LOG(2, "lane %" PRIu64 " internal redo failed: %d", j, err);
			return err; /* return 0 */
		}
	}
	return 0;
}

Ref:

return err;

@janekmi janekmi added Priority: 2 high Type: Bug A previously unknown bug in PMDK labels Jan 31, 2024
@janekmi janekmi added this to the 2.1.0 milestone Jan 31, 2024
@janekmi janekmi mentioned this issue Jan 31, 2024
1 task
@janekmi janekmi modified the milestones: 2.1.0, 2.x Feb 8, 2024
@grom72 grom72 modified the milestones: 2.x, 2.1.1 Feb 12, 2024
@grom72 grom72 added the libpmemobj src/libpmemobj label Mar 25, 2024
@grom72 grom72 modified the milestones: 2.1.1, 2.x Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libpmemobj src/libpmemobj Priority: 2 high Type: Bug A previously unknown bug in PMDK
Projects
None yet
Development

No branches or pull requests

2 participants