Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default of thread inheritance #113

Closed
dktapps opened this issue May 15, 2023 · 1 comment
Closed

Change default of thread inheritance #113

dktapps opened this issue May 15, 2023 · 1 comment

Comments

@dktapps
Copy link
Member

dktapps commented May 15, 2023

While we can't yet get rid of thread code inheritance, we can reduce its performance impact by disabling inheritance by default.

In practice, most people will rely on autoloading anyway, which is the preferred strategy, since this takes less memory and is more reliable. Code inheritance also has a massive performance cost in large applications (see #63), so this feature is just causing unnecessary slowdowns.

A more practical default setting would probably be INHERIT_INI | INHERIT_COMMENTS. (INHERIT_COMMENTS is needed for internal technical reasons - copied Runnable classes won't correctly inherit their doc comments without it).

@dktapps
Copy link
Member Author

dktapps commented May 19, 2023

Since b81959d, the start options must be specified by the user.

@dktapps dktapps closed this as completed May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant