Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<IconPicker> should have a onCancel property #1043

Closed
pineaulo opened this issue Oct 21, 2021 · 2 comments
Closed

<IconPicker> should have a onCancel property #1043

pineaulo opened this issue Oct 21, 2021 · 2 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone
3.5.0

Comments

@pineaulo
Copy link

Category

[*] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [3.3.0]

Expected / Desired Behavior / Question

When the icon picker is dismiss, an optionnal onCancel callback should be called.

Observed Behavior

Currently, it is not possible to show a dynamic preview of the icon change since the changes cannot be revert due to a lack of onCancel callback.
@ghost
Copy link

ghost commented Oct 21, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Oct 21, 2021
@pineaulo pineaulo mentioned this issue Oct 21, 2021
Merged
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Oct 23, 2021
@AJIXuMuK AJIXuMuK added this to the 3.5.0 milestone Oct 23, 2021
@AJIXuMuK
Copy link
Collaborator

Thank you @pineaulo for reporting and providing the PR!

@estruyf estruyf mentioned this issue Dec 3, 2021
Merged
@AJIXuMuK AJIXuMuK closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Milestone
3.5.0
Development

No branches or pull requests
2 participants
@AJIXuMuK @pineaulo