Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilePicker Recents tab selection is not visible #1048

Closed
MonalisaBaltatescu opened this issue Oct 25, 2021 · 5 comments
Closed

FilePicker Recents tab selection is not visible #1048

MonalisaBaltatescu opened this issue Oct 25, 2021 · 5 comments
Assignees
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@MonalisaBaltatescu
Copy link

In the Recents tab I can select the files but the selection circle is shown only on hover

Category

[ ] Enhancement

[x] Bug

[ ] Question

Version

SPFx 1.12.1
sp controls 1.12.1

Expected / Desired Behavior / Question

For the sake of consistency, I expect the files in the recent tabs to be displayed as a list (same as OneDrive or Site Files). The selected file should be visible.

Observed Behavior

image
The files are displayed as tiles, taking so much space and the selection circle is visible only on hover. Not mobile-friendly.

Steps to Reproduce

Add a FilePicker component and go to the Recents tab.

@ghost
Copy link

ghost commented Oct 25, 2021

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Oct 25, 2021
@MonalisaBaltatescu
Copy link
Author

I would like to work on this :) Please assign me to the issue

@aaclage
Copy link
Contributor

aaclage commented Oct 25, 2021

@MonalisaBaltatescu
will be important to include/reference one of the 2 administrators (@AJIXuMuK or @joelfmrodrigues ) to be aware and then they can assign to you.

@joelfmrodrigues can you assign to @MonalisaBaltatescu ?

@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Oct 25, 2021

@MonalisaBaltatescu the consistency should be between our control and OOB file picker. And the out of the box one displays tiles for the Recent tab:
image

For the checkbox - would be great if you fix it. Thank you for that!

@joelfmrodrigues
Copy link
Collaborator

Merged PR to fix the checkbox display issue and will be in the next release

@joelfmrodrigues joelfmrodrigues added this to the 3.5.0 milestone Nov 18, 2021
@AJIXuMuK AJIXuMuK closed this as completed Dec 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

4 participants