Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onChange not triggered when clearing date #1277

Closed
Leif-Frederiksen opened this issue Jul 29, 2022 · 4 comments
Closed

onChange not triggered when clearing date #1277

Leif-Frederiksen opened this issue Jul 29, 2022 · 4 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Milestone

Comments

@Leif-Frederiksen
Copy link
Contributor

Thank you for reporting an issue, suggesting an enhancement, or asking a question. We appreciate your feedback - to help the team understand your
needs please complete the below template to ensure we have the details to help. Thanks!

Please check out the documentation to see if your question is already addressed there. This will help us ensure our documentation is up to date.

Category

[ ] Enhancement

[ X] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 3.9.0 ]

If you are not using the latest release, please update and see if the issue is resolved before submitting an issue.

Expected / Desired Behavior / Question

When using the new "showClearDate" feature of the date/time picker, I would expect the "onChange" event to be triggered, just like when the user enters a date.

Observed Behavior

"onChange" is not triggered.

@ghost
Copy link

ghost commented Jul 29, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@milanholemans
Copy link
Contributor

Hi @Leif-Frederiksen

Thanks for reporting this issue. According to me this is indeed not ideal, the onChange event should be fired every time the date changes in the date picker.
I made a PR to fix this issue.

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. and removed Needs: Triage 🔍 labels Aug 3, 2022
@AJIXuMuK AJIXuMuK added this to the 3.10.0 milestone Aug 3, 2022
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Aug 3, 2022

@Leif-Frederiksen - the fix has been merged and will be included in the next release.

@joelfmrodrigues
Copy link
Collaborator

New release just published, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release.
Projects
None yet
Development

No branches or pull requests

4 participants