Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListItemPicker - use list name as well as GUID to point to list #1355

Closed
DPCamino opened this issue Nov 10, 2022 · 6 comments · Fixed by #1471
Closed

ListItemPicker - use list name as well as GUID to point to list #1355

DPCamino opened this issue Nov 10, 2022 · 6 comments · Fixed by #1471
Assignees
Labels
Good First Issue 🏆 status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@DPCamino
Copy link

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ v3.11 ]

Expected / Desired Behavior / Question

Currently, you need the list GUID to point to a list using the 'listId' property. However, can you also add the option to point to a list name? It would be consistent with other PnP patterns.

If we migrate a solution, create a new list with the same name, or reuse a custom component, we need to make sure to change this property based on the new GUID.

Observed Behavior

Add a new property for listName or modify current property to allow entering the list name instead of the GUID.

Thank you!

@ghost
Copy link

ghost commented Nov 10, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Nov 10, 2022
@github-actions
Copy link

Thank you for submitting your first issue to this project.

@joelfmrodrigues joelfmrodrigues added Good First Issue 🏆 type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Nov 13, 2022
@joelfmrodrigues
Copy link
Collaborator

@SemperYak many thanks for the suggestion. Would you be interested in submitting a pull request with the changes?

@ekapic
Copy link

ekapic commented Nov 24, 2022

I'm working on this issue. I'll submit a PR in a day or two.

@joelfmrodrigues joelfmrodrigues added the status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. label Nov 24, 2022
@joelfmrodrigues joelfmrodrigues added this to the 3.13.0 milestone Dec 13, 2022
@joelfmrodrigues joelfmrodrigues added status:fixed-next-drop Issue will be fixed in upcoming release. and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Dec 13, 2022
@joelfmrodrigues
Copy link
Collaborator

@SemperYak the PR from @ekapic has been merged and the changes will be part of the next release.
Thanks for the great suggestion

@DPCamino
Copy link
Author

Wonderful!
Thank you @joelfmrodrigues and @ekapic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue 🏆 status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants