-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FilePicker - Tile view issue on first render #1558
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
Thank you for submitting your first issue to this project. |
Hey @DMichev many thanks for reporting this issue. Quickly checked the lines you mentioned and it does seem that the page width is being set to the same value as the column width, so it will fit only one item per line. Would you be interested in trying to fix this and submit a pull request? |
Hi @joelfmrodrigues. Manual calculation can't help here. I found another way - re-render the component makes FluentUI List component know its surface width. It is in #1559 |
PR merged, will be in the next beta release (in a few minutes) and also part of the next major release. Thanks! |
New release just published, closing |
Category
[ ] Enhancement
[ X] Bug
[ ] Question
Version
Please specify what version of the library you are using: [ 1.15.0 ]
Expected / Desired Behavior / Question
"Tiles" view should use all available space for rendering the items on first render
Observed Behavior
On initial rendering "Tiles" view option shows its items in a single column with fixed width of 232px.
After selecting an item or perform window resizing - it renders properly.
I think the problem comes from these default values (lines 100-102):
https://github.com/pnp/sp-dev-fx-controls-react/blob/dev/src/controls/filePicker/controls/TilesList/TilesList.tsx#L98
Without setting the container width on this line, it works correctly - https://github.com/pnp/sp-dev-fx-controls-react/blob/dev/src/controls/filePicker/controls/TilesList/TilesList.tsx#L150
Steps to Reproduce
Open FilePicker and navigate to a folder. Make sure "View option" is set to "Tiles". It will render the elements in a single fixed-width column.
The text was updated successfully, but these errors were encountered: