Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Print List Item Command View Set extension to latest version of SPFx - Refresh Rangers Hacktoberfest Event #1406

Open
Adam-it opened this issue Sep 29, 2024 · 5 comments · May be fixed by #1424
Assignees
Labels
Good First Issue 🏆 hacktoberfest status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail.

Comments

@Adam-it
Copy link
Contributor

Adam-it commented Sep 29, 2024

🎯Aim

The aim of this issue is to upgrade the Print List Item Command View Set extension sample to the latest version of SPFx (1.20)

🤔 Tips how to get started

To support you in this issue you may use the below tooling:

📣 What's this event all about

Refresh Rangers is a unique Hacktoberfest event aiming to update our most popular samples 🚀.
During this, you may obtain a unique Microsoft 365 & Power Platform Community badge - Refresh Rangers 🎖️
To obtain this badge besides opening a PR you also need to opt-in the Microsoft 365 & Power Platform Community Recognition Program and fill out this form

@NishkalankBezawada
Copy link
Contributor

Hey @Adam-it,

I'll take this too :)

Thanks,
Nishkalank

@Adam-it Adam-it added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. and removed help wanted labels Oct 3, 2024
@NishkalankBezawada
Copy link
Contributor

NishkalankBezawada commented Oct 10, 2024

Hello @Adam-it ,

This project seems to have dependencies which will not work with react v17. I would like to give a try to upgrade to spfx v1.11.0 since, later versions of spfx has a significant breaking changes too. This might take some time, but I suggest to upgrade to spfx v1.11.0 and then try to do an incremental upgrade. Your suggestion please.

Thanks,
Nishkalank

@Adam-it
Copy link
Contributor Author

Adam-it commented Oct 10, 2024

Hello @Adam-it ,

This project seems to have dependencies which will not work with react v17. I would like to give a try to upgrade to spfx v1.11.0 since, later versions of spfx has a significant breaking changes too. This might take some time, but I suggest to upgrade to spfx v1.11.0 and then try to do an incremental upgrade. Your suggestion please.

Thanks,
Nishkalank

What if we try to upgrade gradually but in a single PR? So first commit changes to upgrade to v1.11 and then based on this commit changes to upgrade to v1.20?

@NishkalankBezawada
Copy link
Contributor

NishkalankBezawada commented Oct 10, 2024

Hello @Adam-it ,
This project seems to have dependencies which will not work with react v17. I would like to give a try to upgrade to spfx v1.11.0 since, later versions of spfx has a significant breaking changes too. This might take some time, but I suggest to upgrade to spfx v1.11.0 and then try to do an incremental upgrade. Your suggestion please.
Thanks,
Nishkalank

What if we try to upgrade gradually but in a single PR? So first commit changes to upgrade to v1.11 and then based on this commit changes to upgrade to v1.20?

Thats the idea, So now the first commit is of v1.11.0, I am trying to upgrade to next version which is spfx v1.13.0 with node -v 14.21.3

Thanks,
Nishkalank

@NishkalankBezawada
Copy link
Contributor

NishkalankBezawada commented Oct 10, 2024

Hey @Adam-it, Quick update, I upgraded to v1.13.0, now upgrading to v1.15.0.

Now, its upgraded to v1.15.0, next step is to upgrade to the latest version of spfx ;)

//Nishkalank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue 🏆 hacktoberfest status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants