Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ethereum.enable promise is not working when app pass-locked #424

Open
ilanolkies opened this issue Nov 12, 2020 · 2 comments
Open

Ethereum.enable promise is not working when app pass-locked #424

ilanolkies opened this issue Nov 12, 2020 · 2 comments
Labels
duplicate This issue or pull request already exists

Comments

@ilanolkies
Copy link

What browser and version did you use?

Chrome latest

What operating system did you use?

Mac OS

Do you have screenshots showing the problem?

Screen Shot 2020-11-12 at 20 29 45

What is your issue?

In the screenshot I try to show 2 different behaviours that work unexpected:

  1. The wallet does not pop up when sending window.ethereum.enable() when the user has not input their password
  2. When building dapps, the Promise gets resolved with unexpected result. This makes dapps working with Metamask have to handle Nifty login in a different manner. I think this does not make sense and the app should pop up and request pass once the developer triggers enable.
@vbaranov vbaranov added the duplicate This issue or pull request already exists label Nov 13, 2020
@vbaranov
Copy link
Collaborator

Duplicate of #222

@vbaranov vbaranov marked this as a duplicate of #222 Nov 13, 2020
@ilanolkies
Copy link
Author

ilanolkies commented Nov 13, 2020 •
edited
Loading

It is mor than just UI. Developers expect that promise not to resolve until the flow is finished.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vbaranov @ilanolkies