-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If the "check" requirements are not met, the coverage method is never called #37
Comments
does it work with this would need to be refactor to allow the coverage files to be created and event emitted regardless of the threshold, but would break current implementations |
I thought of that - the problem with |
could implement a new option |
Thanks for linking to the issue I opened! Indeed they seem quite similar. Consider calling the new option |
If the "check" requirements are not met, the coverage method is never called.
The problem with this is that it means that you will never get coveralls.io to see your coverage when it's below the required threshold. This is when you would MOST want to be able to see the details of the coverage.
Right now I am having to put check at zero to force it to always go to coveralls.io, but this means that my Travis CI build shows passing when I would in fact like it to be failing when the coverage isn't good enough.
At least make it an option maybe?
The text was updated successfully, but these errors were encountered: