Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Yarn to v4.0, Node to v20 and fix the docker image test #568

Open
igoychev opened this issue Oct 26, 2023 · 0 comments
Open

upgrade Yarn to v4.0, Node to v20 and fix the docker image test #568

igoychev opened this issue Oct 26, 2023 · 0 comments
Labels
type: enhancement New feature or request

Comments

@igoychev
Copy link
Contributor

Which area(s) of Podkrepi.bg are affected? (leave empty if unsure)

No response

Describe the feature you'd like to request

Two things to upgrade and one to fix:

  • Yarn 4.0 is out and will be great to upgrade
  • The frontend is updated to Node v20, so let's update in Docker image to v20 too
  • The github action that tests the docker images is building the master instead of the PR code, so it needs to be fixed to use the context from the git checkout in the previous step(see screenshot below)
Screenshot 2023-10-26 at 10 47 51

Describe the solution you'd like

The fix of the Docker checkout action is to add "context: ." as per the path context docs after this line here:

Describe alternatives you've considered

No response

@igoychev igoychev added the type: enhancement New feature or request label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant