Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EPro Bug - Media Carousel #2702

Closed
norewp opened this issue Nov 6, 2017 · 5 comments
Closed

EPro Bug - Media Carousel #2702

norewp opened this issue Nov 6, 2017 · 5 comments
Labels
component/swiper References any instance of the Swiper.js dependency. product/pro Indicates if the referenced component is part of the Elementor Pro plugin.

Comments

@norewp
Copy link

norewp commented Nov 6, 2017

Came across this issue on FB: https://www.facebook.com/matt.tozer.10/videos/1577816155590827/ and can confirm that it appears to be a bug.

Issue 1: Switching from Slide to Fade mode breaks item count layout i.e. 3 items selected but only one displayed in Fade mode.

Issue 2: Switching the Pause on Interaction to Yes has no effect as the animation continues when hovered.

@bainternet bainternet added component/swiper References any instance of the Swiper.js dependency. product/pro Indicates if the referenced component is part of the Elementor Pro plugin. labels Nov 7, 2017
@bainternet
Copy link
Contributor

@norewp

issue 1: Not a real issue since the "Slides Per View" should be visible only when the effect is set to "slide", we will correct that.

issue 2: Again not an issue because hover is not an interaction, if you click on next/previous slide arrows, that is an interaction and as expected the animation stops once you do that.

Thanks for reporting.

@norewp
Copy link
Author

norewp commented Nov 7, 2017

Thank you @bainternet and glad to hear that #1 will be taken care of.

As #2 - I'd argue that from an end user's perspective, a hove action is an interaction event for the module in a similar fashion as it is for a menu item - the interaction triggers a certain event i.e. dropdown items for the menu. Therefore one would expect the slider to pause when hovered over.

I'd classify Hover, Swipe and/or navigation Clicks to be of interaction action with the functionality of the module!

@bainternet
Copy link
Contributor

:)

We use swiper library for the media carousel. They defined user interaction as such, and that is why the control in Elementor is called "Pause on Interaction" and not "pause on hover".

So again we don't see this as an issue, but as you know, we are always looking to add more feature and tweaks to our widgets, and maybe "pause on Hover" will be one of them.

Again thanks for your input.

kobizz added a commit to kobizz/elementor that referenced this issue Nov 7, 2017
@norewp
Copy link
Author

norewp commented Nov 7, 2017

Cool. Let's consider this a request for "pause on Hover" as a feature request shall we? :)

@arielk arielk closed this as completed Nov 9, 2017
@ecomm-michael
Copy link

I agree that an interaction IS a hover. Especially when something is moving.

Imagine using a carousel for a slider of partners, or for advertisers etc. They have the ability to have links right? So if someone hovers over the carousel, it would only make sense to pause it so they can click instead of making the end-user chase it, right? This shouldn't be a toggle separately, it should be included with the interaction button, and in my opinion, this should be default behavior that you have to specifically opt out of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/swiper References any instance of the Swiper.js dependency. product/pro Indicates if the referenced component is part of the Elementor Pro plugin.
Projects
None yet
Development

No branches or pull requests

4 participants