Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Image Size" control to the "Image Box" widget #3251

Merged
merged 2 commits into from
Feb 4, 2018
Merged

Add "Image Size" control to the "Image Box" widget #3251

merged 2 commits into from
Feb 4, 2018

Conversation

ramiy
Copy link
Contributor

@ramiy ramiy commented Jan 20, 2018 •
edited
Loading

Fixing #3098

image-box

This way I can set Custom sizes and use less bandwidth using smaller images!

image-box-custom-sizes

@arielk arielk added this to the 2.0.0 milestone Jan 21, 2018
@arielk
Copy link
Member

arielk commented Jan 22, 2018 •
edited
Loading

@KingYes Needs further review of UI team before merge

@ramiy
Copy link
Contributor Author

ramiy commented Jan 24, 2018

@KingYes

@kobizz
Copy link
Member

kobizz commented Feb 1, 2018

Looks good

@KingYes KingYes merged commit 5ac3c0f into elementor:release/2.0.0 Feb 4, 2018
@ramiy ramiy deleted the image-box branch February 4, 2018 16:19
@ramiy
Copy link
Contributor Author

ramiy commented Feb 4, 2018 •
edited
Loading

@KingYes Ok, so we have a problem with this PR, the new control uses the image_size name.

But this specific widget already uses the image_size name in a different control.

This is why Travis failed. I see a PHP notice in my debug.log file.

@ramiy ramiy restored the image-box branch February 4, 2018 21:06
@ramiy ramiy mentioned this pull request Feb 14, 2018
Merged
@ramiy
Copy link
Contributor Author

ramiy commented Feb 15, 2018

Also fixing #928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ramiy @arielk @kobizz @KingYes