Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands time out when terminal is focused #14

Open
sbungartz opened this issue Oct 23, 2022 · 4 comments
Open

Commands time out when terminal is focused #14

sbungartz opened this issue Oct 23, 2022 · 4 comments

Comments

@sbungartz
Copy link

sbungartz commented Oct 23, 2022

Whenever the built in terminal of VS Code has focus, commands issued using user.vscode are no longer working. Instead you get a time out in talon log.

For example:

  1. Open a VS Code window and focus the built in terminal.
  2. Say please
  3. Nothing happens, except the following error showing up in talon log:
talon.scripting.talon_script.TalonScriptError: 
 in script at /home/simon/.talon/user/knausj_talon/apps/vscode/vscode.talon:16:
 > user.vscode('workbench.action.showCommands')
Exception: Timed out waiting for response

I am on

  • Ubuntu 20.04
  • talon beta v0.3.1-41-g7516 (41)
  • knausj_talon 644d330be80bddfe7bfc314a15903185b3111cf7
  • VS Code 1.72.2
  • Command Server Plugin v0.8.2

Maybe this is a Linux thing, but I have no idea why focusing the terminal would stop command server from reading files...

@AndreasArvidsson
Copy link
Contributor

Weird. This appears to be working fine on windows.

@sbungartz
Copy link
Author

I have found a way to make this work. After adding command-server.runCommand to the list of commands whose keybindings will always be handled by VS Code (terminal.integrated.commandsToSkipShell), it works!

image

Otherwise the key combination seems to be handled by the terminal.

Do you know if there is a way for this plugin to insert itself into this setting automatically?

@pokey
Copy link
Owner

pokey commented Oct 24, 2022

Yes that's the one; couldn't remember the setting name. Glad you were able to find it

Yes I believe there is a way to do that. Settings can contribute default values, and if that doesn't work they can actually just modify settings directly

@frosk1
Copy link

frosk1 commented Sep 26, 2023

had the same issue and it could be resolved with adding "command-server.runCommand" to terminal.integrated.commandsToSkipShell like @sbungartz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants