Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Persistence] Fix Persistence Module TODOs - Multiple Write Contexts #149 #212

Closed
7 tasks
jessicadaugherty opened this issue Sep 12, 2022 · 3 comments
Closed
7 tasks
Assignees
Labels
code health Nice to have code improvement core Core infrastructure - protocol related persistence Persistence specific changes

Comments

@jessicadaugherty
Copy link
Contributor

Objective

A general cleanup issue is needed to tackle TODO's and ensure the persistence module is usable/readable by handling multiple write contexts as part of #172.

Origin Document

Should follow issue-#128, issue-#105, issue-#147 and issue-#148 the persistence module is messier and more difficult to understand than the developers would want for organic external contribution.

Goals / Deliverables

  • Handle multiple write contexts. See the TODO near the TestTwoWriteContextsSameHeight test in persistence/test/module_test.go.

General issue checklist

  • Update the appropriate CHANGELOG
  • Update the README
  • If applicable, update the source code tree explanation
  • If applicable, add or update a state, sequence or flowchart diagram using mermaid
  • Update any relevant global documentation & references
  • Document small issues / TODOs along the way

Creator: @andrewnguyen22
Co-creator: @Olshansk

@Olshansk Olshansk added persistence Persistence specific changes code health Nice to have code improvement labels Sep 19, 2022
@Olshansk Olshansk added the core Core infrastructure - protocol related label Sep 19, 2022
@Olshansk Olshansk self-assigned this Sep 28, 2022
@Olshansk
Copy link
Member

@andrewnguyen22 Did we agree that there should only ever be one write context at any point in time? If so, I think we can close this out.

@Olshansk
Copy link
Member

@andrewnguyen22 Bump on question above

@Olshansk
Copy link
Member

Olshansk commented Nov 9, 2022

Going to close this out given the current state of persistence, but lmk if it should be something we re-explore.

@Olshansk Olshansk closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Nice to have code improvement core Core infrastructure - protocol related persistence Persistence specific changes
Projects
Status: Done
Development

No branches or pull requests

2 participants