Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consensus] When starting LocalNet from scratch, the first TriggerNextView leads to height 2 and not 1 #441

Open
9 tasks
Tracked by #890
deblasis opened this issue Jan 17, 2023 · 1 comment
Assignees
Labels
bug Something isn't working - expected behaviour is incorrect consensus Consensus specific changes core starter task Good for newcomers, but aimed at core team members though still open for everyone

Comments

@deblasis
Copy link
Contributor

Objective

Identify the root cause and fix the misbehaviour

Origin Document

While running LocalNet from the genesis state, the first TriggerNextView advances consensus to height 2 and not 1 as expected

Goals

  • Investigate the misbehaviour
  • Fix the issue

Deliverable

  • A PR that shows the correct behaviour

Non-goals / Non-deliverables

  • Changes in the consensus logic

General issue deliverables

  • Update the appropriate CHANGELOG(s)
  • Update any relevant local/global README(s)
  • Update relevant source code tree explanations
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • Task specific tests or benchmarks: make ...
  • New tests or benchmarks: make ...
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @deblasis
Co-Owners: @Olshansk, @gokutheengineer

@deblasis deblasis added bug Something isn't working - expected behaviour is incorrect consensus Consensus specific changes labels Jan 17, 2023
@Olshansk
Copy link
Member

Wanted to provide additional context.

The video linked in this comment shows that behaviour.

Without diving into the issue, I believe it has to do with the fact that genesis (i.e. block height = 0) is a special case, which is why the first TriggerNextView goes straight from 0->2. I have not seen a jump by two in other cases myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working - expected behaviour is incorrect consensus Consensus specific changes core starter task Good for newcomers, but aimed at core team members though still open for everyone
Projects
Status: Up Next
Development

No branches or pull requests

5 participants