Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CONSENSUS] Fix (pseudo)random ranges in TestSortition #470

Open
3 of 4 tasks
Tracked by #890
gokutheengineer opened this issue Jan 27, 2023 · 0 comments
Open
3 of 4 tasks
Tracked by #890

[CONSENSUS] Fix (pseudo)random ranges in TestSortition #470

gokutheengineer opened this issue Jan 27, 2023 · 0 comments
Assignees
@red-0ne
Labels
code health Nice to have code improvement consensus Consensus specific changes testing Defining, adding, automating or modifying tests
Milestone
M1: Pocket PoS (P...

Comments

@gokutheengineer
Copy link
Contributor

Objective

Fix VRF range in test scenarios to remove somewhat arbitrary behavior on rarely failing TestSortition test to have deterministic test.

Origin Document

Screen Shot 2023-01-27 at 20 24 27

Screen Shot 2023-01-27 at 20 24 47

Goals

  • Deterministic TestSortition test.

Deliverable

  • Update ranges in TestSortition test.

Non-goals / Non-deliverables

  • Change business logic.

General issue deliverables

  • Update the appropriate CHANGELOG(s)

Testing Methodology

  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @gokutheengineer
@gokutheengineer gokutheengineer added consensus Consensus specific changes code health Nice to have code improvement testing Defining, adding, automating or modifying tests labels Jan 27, 2023
@gokutheengineer gokutheengineer self-assigned this Jan 27, 2023
@gokutheengineer gokutheengineer changed the title [CONSENSUS] Fix (pseudo)random [CONSENSUS] Fix (pseudo)random Ranges in TestSortition Jan 27, 2023
@gokutheengineer gokutheengineer changed the title [CONSENSUS] Fix (pseudo)random Ranges in TestSortition [CONSENSUS] Fix (pseudo)random ranges in TestSortition Jan 29, 2023
@Olshansk Olshansk mentioned this issue Jul 10, 2023
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@red-0ne red-0ne

Labels
code health Nice to have code improvement consensus Consensus specific changes testing Defining, adding, automating or modifying tests
Projects
V1 Dashboard
Status: Backlog
Milestone
M1: Pocket PoS (Proof of Stake)
Development

No branches or pull requests
2 participants
@red-0ne @gokutheengineer