Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONSENSUS] Add Quorum Certificate verification tests #615

Open
10 tasks
Tracked by #890
gokutheengineer opened this issue Mar 24, 2023 · 1 comment
Open
10 tasks
Tracked by #890

[CONSENSUS] Add Quorum Certificate verification tests #615

gokutheengineer opened this issue Mar 24, 2023 · 1 comment
Assignees
Labels
consensus Consensus specific changes

Comments

@gokutheengineer
Copy link
Contributor

Objective

Nodes perform Quorum Certificate (QC) verification when committing a block in the consensus process, and for validating blocks received via state synchronization. The objective of this issue is to implement QC verification tests.

Goals

  • Implement QC verification tests in the consensus e2e_tests/hotstuff_test.go
  • Add more QC verification tests to the e2e_tests/hotstuff_test.go.

Deliverable

  • QC verification tests implementation.
  • Ensuring QC verification process is correct with extensive tests.

Non-goals / Non-deliverables

  • Change business logic.

General issue deliverables

  • Update the appropriate CHANGELOG(s)
  • Update any relevant local/global README(s)
  • Update relevant source code tree explanations
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • Task specific tests or benchmarks: make ...
  • New tests or benchmarks: make ...
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @gokutheengineer
Co-Owners: @Olshansk

@gokutheengineer gokutheengineer self-assigned this Mar 24, 2023
@gokutheengineer gokutheengineer added the consensus Consensus specific changes label Mar 24, 2023
@Olshansk
Copy link
Member

@gokutheengineer Could you please link to the place in the codebase where the placeholders for the business logic and tests currently live?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Consensus specific changes
Projects
Status: Backlog
Development

No branches or pull requests

3 participants