Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Consensus] Remove the dependency of state sync on the FSM #821

Open
12 tasks
Tracked by #890
Olshansk opened this issue Jun 14, 2023 · 0 comments
Open
12 tasks
Tracked by #890

[Consensus] Remove the dependency of state sync on the FSM #821

Olshansk opened this issue Jun 14, 2023 · 0 comments
Assignees
Labels
consensus Consensus specific changes

Comments

@Olshansk
Copy link
Member

Objective

Remove the dependency of state sync on the FSM.

Origin Document

While working on #352, it became evident that the Finite State Machine adds complexity to the implementation and understanding of state sync rather than simplify it.

Goals

  • Reduce the complexity of the codebase
  • Reduce cognitive load on future owners of the state sync submodule
  • Make future optimizations of state sync simpler
  • Decouple state sync logic from the larger scope of the node operations
  • Prepare the codebase to remove the FSM

Deliverable

  • Remove all technical relationships, constants, variables, interfaces, etc between state sync and the FSM
  • Updated documentation that remove all relationships between State Sync and the FSM
  • Follow up GitHub tickets to remove the FSM altogether

Non-goals / Non-deliverables

  • Removing the FSM from the codebase
  • Further optimizations to state sync

General issue deliverables

  • Update the appropriate CHANGELOG(s)
  • Update any relevant local/global README(s)
  • Update relevant source code tree explanations
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • Task specific tests or benchmarks: make ...
  • New tests or benchmarks: make ...
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md
  • k8s LocalNet: verify a k8s LocalNet is still functioning correctly by following the instructions here

Creator: @Olshansk

@Olshansk Olshansk added the consensus Consensus specific changes label Jun 14, 2023
@Olshansk Olshansk self-assigned this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Consensus specific changes
Projects
Status: Up Next
Development

No branches or pull requests

2 participants