Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Persistence] Implement Local context for persistence module #826

Open
12 tasks
adshmh opened this issue Jun 15, 2023 · 6 comments
Open
12 tasks

[Persistence] Implement Local context for persistence module #826

adshmh opened this issue Jun 15, 2023 · 6 comments
Assignees
Labels
persistence Persistence specific changes

Comments

@adshmh
Copy link
Contributor

adshmh commented Jun 15, 2023

Objective

Implement the Local context of persistence module, introduced by #803.

Origin Document

Introduced by #803, as part of work on #754.
Local context is required to complete the servicer functionality.

The interface to be implemented:

image

The usage of Local context of persistence module in servicer:

image

and

image

Goals

  • Implement the Local context to the extent required by the servicer.

Deliverable

  • Updated Persistence module
  • Updated Documentation
  • Updated minimal E2E tests to validate the functionality

General issue deliverables

  • Update the appropriate CHANGELOG(s)
  • Update any relevant local/global README(s)
  • Update relevant source code tree explanations
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • Task specific tests or benchmarks: make ...
  • New tests or benchmarks: make ...
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md
  • k8s LocalNet: verify a k8s LocalNet is still functioning correctly by following the instructions here

Creator: @adshmh
Co-Owners: [@Olshansk ]

@adshmh adshmh added the persistence Persistence specific changes label Jun 15, 2023
@adshmh adshmh self-assigned this Jun 15, 2023
@Olshansk
Copy link
Member

Olshansk commented Jun 15, 2023

@adshmh You should mark yourself as the creator at the bottom of the ticket by referencing your github username.

Screenshot 2023-06-15 at 1 15 58 PM

You can add co-owners if someone else has context into the work. @Olshansk for this specific one.

Also, please update the iteration (if you plan on doing this now or in a future iteration) and change to Backlog or up next appropriately.

Screenshot 2023-06-15 at 1 14 49 PM

@Olshansk
Copy link
Member

@adshmh For tickets like this, to avoid spending too much time on the context in the origin document (which would be nice but I know is overkill), feel free to just insert a screenshot from a different PR or discussion we had.

@adshmh
Copy link
Contributor Author

adshmh commented Jun 29, 2023

@adshmh For tickets like this, to avoid spending too much time on the context in the origin document (which would be nice but I know is overkill), feel free to just insert a screenshot from a different PR or discussion we had.

Done, thank you for the hint.

@h5law
Copy link
Contributor

h5law commented Jul 9, 2023

@adshmh is the local context going to be a postgres instance or a badger db?

@Olshansk
Copy link
Member

@adshmh is the local context going to be a postgres instance or a badger db?

@adshmh Friendly bump on this.

@adshmh
Copy link
Contributor Author

adshmh commented Jul 17, 2023

@adshmh is the local context going to be a postgres instance or a badger db?

@adshmh Friendly bump on this.

Thank you for the reminder.
I think it is going to be using SMST backed by the kvstore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
persistence Persistence specific changes
Projects
Status: Up Next
Development

No branches or pull requests

3 participants