Skip to content
This repository has been archived by the owner on Oct 14, 2023. It is now read-only.

SSL for docs #386

Closed
astrojuanlu opened this issue Jun 11, 2018 · 6 comments
Closed

SSL for docs #386

astrojuanlu opened this issue Jun 11, 2018 · 6 comments
Assignees

Comments

@astrojuanlu
Copy link
Member

🐞 Problem

https://poliastro.readthedocs.io works, but https://docs.poliastro.space doesn't.

🎯 Goal

HTTPS all the things!

💡 Possible solutions

Find out how to get a SSL certificate, perhaps with Let's Encrypt https://letsencrypt.org/.

📋 Steps to solve the problem

  • Comment below about what you've started working on.
  • Add, commit, push your changes
  • Submit a pull request and add this in comments - Addresses #<put issue number here>
  • Ask for a review in comments section of pull request
  • Celebrate your contribution to this project 🎉
@astrojuanlu astrojuanlu added this to the 0.10 milestone Jun 11, 2018
@astrojuanlu astrojuanlu self-assigned this Jun 11, 2018
@astrojuanlu
Copy link
Member Author

This is the key part of the docs:

http://docs.readthedocs.io/en/latest/alternate_domains.html#cname-ssl

We don’t support SSL for CNAMEs on our side, but you can enable support if you have your own server.

@astrojuanlu
Copy link
Member Author

@astrojuanlu
Copy link
Member Author

This is in the works readthedocs/readthedocs.org#2652 (comment) so I won't take any action from the poliastro side. Closing!

@astrojuanlu astrojuanlu removed this from the 0.10 milestone Jul 5, 2018
@astrojuanlu
Copy link
Member Author

Now it works! We have to change the links everywhere.

https://docs.poliastro.space/

@astrojuanlu astrojuanlu reopened this Aug 3, 2018
@astrojuanlu
Copy link
Member Author

@astrojuanlu
Copy link
Member Author

HTTPS everywhere!

screenshot_2018-08-14 edit domains read the docs

readthedocs/readthedocs.org#4483

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant