Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Quebert controllers response to method calls instead of raise from the job. #13

Open
bradgessler opened this issue May 12, 2015 · 0 comments
Labels
Milestone

Comments

@bradgessler
Copy link
Contributor

Quebert jobs raise classes that are caught by Quebert controllers to manage job life-cycles. Refactor jobs to call methods on the controller. e.g. job.retry could call controller.retry(job) if the retry method is present on the controller (or have a base controller that doesn't perform an operation on a retry).

All of the exceptions implemented at https://github.com/polleverywhere/quebert/blob/multiple-tubes/lib/quebert/job.rb#L24-33 should be moved into a controller. Then methods like https://github.com/polleverywhere/quebert/blob/multiple-tubes/lib/quebert/job.rb#L94-105 can be delegated to said controller to deal with all job concerns in relation to the backend.

@bradgessler bradgessler changed the title Refactor Quebert controllers do not perform signalling via "raise" Refactor Quebert controllers do not perform signalling via raise May 12, 2015
@bradgessler bradgessler added this to the 2.x milestone May 12, 2015
@bradgessler bradgessler changed the title Refactor Quebert controllers do not perform signalling via raise Refactor Quebert controllers response to method calls instead of raise from the job. May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant