You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Change the default to log the exception and bury the job for later inspection. Also make the object passed into the error proc a custom struct/class for better error encapsulation.
We should consider moving as much error handling, etc. into the job as we can. I think this could eliminate the need for all the different controllers we have and most of our hooks if we can pull this off.
The current default behavior of the quebert worker loop is to exit the
quebert
process when an exception is raised:https://github.com/polleverywhere/quebert/blob/master/lib/quebert/worker.rb#L33
Change the default to log the exception and bury the job for later inspection. Also make the object passed into the error proc a custom struct/class for better error encapsulation.
Quebert.logger.error
and bury the job.Quebert::Worker::Error
object that's passed into the exception handler proc via https://github.com/polleverywhere/quebert/blob/master/lib/quebert/worker.rb#L26.#to_s
method returns all of the info needed for thelogger.error
call (e.g.Quebert.logger.error(worker_error)
Since this breaks the 3.0 error handler API this should belong on Quebert 4.0.
The text was updated successfully, but these errors were encountered: