Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default worker exception handler should not exit the quebert worker loop #19

Open
3 tasks
bradgessler opened this issue Aug 1, 2015 · 1 comment
Open
3 tasks
Labels
Milestone

Comments

@bradgessler
Copy link
Contributor

The current default behavior of the quebert worker loop is to exit the quebert process when an exception is raised:

https://github.com/polleverywhere/quebert/blob/master/lib/quebert/worker.rb#L33

Change the default to log the exception and bury the job for later inspection. Also make the object passed into the error proc a custom struct/class for better error encapsulation.

Since this breaks the 3.0 error handler API this should belong on Quebert 4.0.

@bradgessler
Copy link
Contributor Author

We should consider moving as much error handling, etc. into the job as we can. I think this could eliminate the need for all the different controllers we have and most of our hooks if we can pull this off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant